Github user nsuke commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1084#discussion_r93367768
  
    --- Diff: compiler/cpp/src/thrift/generate/t_swift_3_generator.cc ---
    @@ -0,0 +1,2553 @@
    +/*
    --- End diff --
    
    Assigning simple "--gen swift" to this one sounds good to me, given the 
Swift 2.x situation and this beeing pure Swift implementation.
    
    In general, though, removing is hard.
    The most natural course of action would be to keep current one as an 
generator switch like "swift:cocoa".
    
    For completely replacement, we need ordinal considerations for any breaking 
changes.
    How hard it is to migrate existing users' code ?
    It seems to me that anyone who extended library code (inheritance etc) 
would be in a huge trouble.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to