[
https://issues.apache.org/jira/browse/THRIFT-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840532#comment-15840532
]
Chandler May commented on THRIFT-4042:
--
Clarified that the bug occurs when thrift is installed via
[
https://issues.apache.org/jira/browse/THRIFT-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandler May updated THRIFT-4042:
-
Description:
We recently switched to thrift 0.10.0 with accelerated protocols and started
Chandler May created THRIFT-4042:
Summary: ExtractionError when using accelerated thrift in a
multiprocess test
Key: THRIFT-4042
URL: https://issues.apache.org/jira/browse/THRIFT-4042
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840423#comment-15840423
]
ASF GitHub Bot commented on THRIFT-3854:
Github user jsirois commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840422#comment-15840422
]
ASF GitHub Bot commented on THRIFT-3854:
Github user jsirois commented on a diff in the pull
I noted a few minor things, but not bugs - looks good to me.
On Thu, Jan 26, 2017 at 1:38 PM, Jim King wrote:
> I’d like someone more familiar with the Java runtime to review the change
> before I merge it. It passed CI and has a nice unit test.
>
>
Github user jsirois commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1081#discussion_r98087206
--- Diff: lib/java/src/org/apache/thrift/transport/TFramedTransport.java ---
@@ -123,6 +123,12 @@ public void consumeBuffer(int len) {
Github user jsirois commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1081#discussion_r98087986
--- Diff:
lib/java/src/org/apache/thrift/transport/TFastFramedTransport.java ---
@@ -164,6 +166,10 @@ public void consumeBuffer(int len) {
I'd like someone more familiar with the Java runtime to review the change
before I merge it. It passed CI and has a nice unit test.
https://github.com/apache/thrift/pull/1081
[Description: Description: simplivity-lg-xsmall]
James E. King, III
Architect
8 Technology Drive, 2nd Floor
Westborough,
[
https://issues.apache.org/jira/browse/THRIFT-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840401#comment-15840401
]
ASF GitHub Bot commented on THRIFT-3854:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1081#discussion_r98086075
--- Diff:
lib/java/test/org/apache/thrift/transport/TestTFastFramedTransport.java ---
@@ -19,6 +19,8 @@
package org.apache.thrift.transport;
[
https://issues.apache.org/jira/browse/THRIFT-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volodymyr Gotra closed THRIFT-4039.
---
Thank you
> Update of Apache Thrift .Net Core lib
> --
>
>
Github user gadLinux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98028242
--- Diff: lib/c_glib/test/Makefile.am ---
@@ -37,16 +37,17 @@ BUILT_SOURCES = \
gen-c_glib/t_test_thrift_test_types.h
AM_CPPFLAGS =
[
https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839959#comment-15839959
]
ASF GitHub Bot commented on THRIFT-3369:
Github user gadLinux commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839956#comment-15839956
]
ASF GitHub Bot commented on THRIFT-3369:
Github user gadLinux commented on a diff in the pull
Github user gadLinux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98027875
--- Diff: lib/c_glib/test/CMakeLists.txt ---
@@ -108,13 +108,6 @@ add_test(NAME testoptionalrequired COMMAND
testoptionalrequired)
[
https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839957#comment-15839957
]
ASF GitHub Bot commented on THRIFT-3369:
Github user gadLinux commented on a diff in the pull
Github user gadLinux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98027723
--- Diff: lib/c_glib/src/thrift/c_glib/transport/thrift_platform_socket.h
---
@@ -0,0 +1,120 @@
+/*
--- End diff --
I tottally agree. It's
Github user gadLinux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98027454
--- Diff: configure.ac ---
@@ -199,6 +196,12 @@ if test "$with_c_glib" = "yes"; then
fi
AM_CONDITIONAL(WITH_C_GLIB, [test "$have_glib2" = "yes" -a
[
https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839953#comment-15839953
]
ASF GitHub Bot commented on THRIFT-3369:
Github user gadLinux commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839745#comment-15839745
]
ASF GitHub Bot commented on THRIFT-3369:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839749#comment-15839749
]
ASF GitHub Bot commented on THRIFT-3369:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839750#comment-15839750
]
ASF GitHub Bot commented on THRIFT-3369:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839747#comment-15839747
]
ASF GitHub Bot commented on THRIFT-3369:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839746#comment-15839746
]
ASF GitHub Bot commented on THRIFT-3369:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839748#comment-15839748
]
ASF GitHub Bot commented on THRIFT-3369:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98002795
--- Diff: lib/c_glib/test/owncloud.level2crm.pem ---
@@ -0,0 +1,59 @@
+-BEGIN CERTIFICATE-
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98003039
--- Diff: configure.ac ---
@@ -199,6 +196,12 @@ if test "$with_c_glib" = "yes"; then
fi
AM_CONDITIONAL(WITH_C_GLIB, [test "$have_glib2" = "yes" -a
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98003689
--- Diff: lib/c_glib/test/Makefile.am ---
@@ -37,16 +37,17 @@ BUILT_SOURCES = \
gen-c_glib/t_test_thrift_test_types.h
AM_CPPFLAGS =
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98003481
--- Diff: lib/c_glib/src/thrift/c_glib/transport/thrift_platform_socket.h
---
@@ -0,0 +1,120 @@
+/*
--- End diff --
This looks a lot like
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98003205
--- Diff: lib/c_glib/Makefile.am ---
@@ -45,6 +45,7 @@ libthrift_c_glib_la_SOURCES = src/thrift/c_glib/thrift.c \
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/930#discussion_r98003634
--- Diff: lib/c_glib/test/CMakeLists.txt ---
@@ -108,13 +108,6 @@ add_test(NAME testoptionalrequired COMMAND
testoptionalrequired)
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839705#comment-15839705
]
Allen George commented on THRIFT-2945:
--
[~anatolikus], [~jensg] - thank you for the kind words, it's
[
https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839530#comment-15839530
]
ASF GitHub Bot commented on THRIFT-3369:
Github user gadLinux commented on the issue:
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/930
I'm rebasing again...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
[
https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839474#comment-15839474
]
ASF GitHub Bot commented on THRIFT-3369:
Github user gadLinux commented on the issue:
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/930
Again a problem with code outside the domain area. Can someone help me to
fix this? Because it's failing on some places where I never touched. Should I
continue doing rebase until everyone fixes
37 matches
Mail list logo