[jira] [Commented] (THRIFT-3859) Unix Domain Socket Support in Objective-C

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949888#comment-15949888 ] ASF GitHub Bot commented on THRIFT-3859: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

2017-03-30 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1031 Hi @clindsay just checking in to see if you had made any progress on adding cross test support for cocoa. If not that's okay... it would be really nice to have it though. --- If your project is

[jira] [Resolved] (THRIFT-4147) Rust: protocol should accept transports with non-static lifetime

2017-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4147. Resolution: Fixed Assignee: James E. King, III Fix Version/s:

[jira] [Commented] (THRIFT-4147) Rust: protocol should accept transports with non-static lifetime

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949880#comment-15949880 ] ASF GitHub Bot commented on THRIFT-4147: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1226: THRIFT-4147: Rust: protocol should accept transpo...

2017-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (THRIFT-4113) Provide a buffer transport for reading/writing in memory byte stream

2017-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4113. Resolution: Fixed Assignee: James E. King, III Fix Version/s:

[GitHub] thrift pull request #1218: export thrift::mem::TBufferTransport

2017-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1218 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (THRIFT-4069) All perl packages should have proper namespace, version syntax, and use proper thrift exceptions

2017-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4069: --- Component/s: Perl - Compiler > All perl packages should have proper namespace,

[jira] [Commented] (THRIFT-4069) All perl packages should have proper namespace, version syntax, and use proper thrift exceptions

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949836#comment-15949836 ] ASF GitHub Bot commented on THRIFT-4069: Github user asfgit closed the pull request at:

[jira] [Resolved] (THRIFT-4069) All perl packages should have proper namespace, version syntax, and use proper thrift exceptions

2017-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4069. Resolution: Fixed Fix Version/s: 0.11.0 > All perl packages should have

[GitHub] thrift pull request #1220: THRIFT-4069: perl library cleanup - namespaces, v...

2017-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift issue #1218: export thrift::mem::TBufferTransport

2017-03-30 Thread sunchao
Github user sunchao commented on the issue: https://github.com/apache/thrift/pull/1218 This change looks good to me, even though I'm also relatively new to Rust. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift issue #1218: export thrift::mem::TBufferTransport

2017-03-30 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1218 Please rebase against upstream/master and force push to kick a new build. I'd like to see CI pass (or get much closer) before merging. --- If your project is set up for it, you can reply to this

[GitHub] thrift issue #1217: TSocket: Don't close connections when failing to read/wr...

2017-03-30 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1217 Please rebase against upstream/master and force push to kick a new build. I'd like to see CI pass (or get much closer) before merging. --- If your project is set up for it, you can reply to this

[GitHub] thrift issue #1216: TNonblockingServer: Fix using uninitialized event_

2017-03-30 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1216 Please rebase against upstream/master and force push to kick a new build. I'd like to see CI pass (or get much closer) before merging. --- If your project is set up for it, you can reply to this

[GitHub] thrift issue #1211: Fix use closed(freed) connections

2017-03-30 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1211 Please rebase this branch against upstream/master and force push to kick off a new build. I would like to see the CI build pass (or get much closer than it is now) before merging. --- If your

[jira] [Commented] (THRIFT-4126) Validate objects in php extension

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949774#comment-15949774 ] ASF GitHub Bot commented on THRIFT-4126: Github user asfgit closed the pull request at:

[jira] [Resolved] (THRIFT-4126) Validate objects in php extension

2017-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4126. Resolution: Fixed Fix Version/s: 0.11.0 Committed - thanks! > Validate

[GitHub] thrift pull request #1215: Thrift 4126

2017-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Assigned] (THRIFT-4142) Add a functional test to check proper handling of required fields in structures

2017-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4142: -- Assignee: James E. King, III > Add a functional test to check proper handling

[jira] [Commented] (THRIFT-4151) Thrift Mutex Contention Profiling (pthreads) should be disabled by default

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949684#comment-15949684 ] ASF GitHub Bot commented on THRIFT-4151: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1229: THRIFT-4151: disable pthread concurrency analysis...

2017-03-30 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1229 THRIFT-4151: disable pthread concurrency analysis code in standard builds You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift

[jira] [Assigned] (THRIFT-4151) Thrift Mutex Contention Profiling (pthreads) should be disabled by default

2017-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4151: -- Assignee: James E. King, III > Thrift Mutex Contention Profiling (pthreads)

[jira] [Commented] (THRIFT-3978) Thrift C++ runtime uses assert to prevent overflows, checks sanity only in debug builds

2017-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949667#comment-15949667 ] ASF GitHub Bot commented on THRIFT-3978: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1228: THRIFT-3978: tighten up pthread mutex implementat...

2017-03-30 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1228 THRIFT-3978: tighten up pthread mutex implementation, removing asserts and replacing them with exceptions You can merge this pull request into a Git repository by running: $ git pull

[GitHub] thrift issue #1215: Thrift 4126

2017-03-30 Thread kufd
Github user kufd commented on the issue: https://github.com/apache/thrift/pull/1215 There is a falg "validate" in thrift generator for php (validate: Generate PHP validator methods\n") And that flag is used in my changes I will try to add tests for both cases: when

[jira] [Created] (THRIFT-4151) Thrift Mutex Contention Profiling (pthreads) should be disabled by default

2017-03-30 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4151: -- Summary: Thrift Mutex Contention Profiling (pthreads) should be disabled by default Key: THRIFT-4151 URL: https://issues.apache.org/jira/browse/THRIFT-4151

[jira] [Updated] (THRIFT-4150) Python server or cpp client do not handle an unimplemented service method gracefully

2017-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4150: --- Summary: Python server or cpp client do not handle an unimplemented service method

[jira] [Created] (THRIFT-4150) Python server or cpp client do not handle the unimplemented method gracefully

2017-03-30 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4150: -- Summary: Python server or cpp client do not handle the unimplemented method gracefully Key: THRIFT-4150 URL: https://issues.apache.org/jira/browse/THRIFT-4150

[jira] [Updated] (THRIFT-455) Compiler flag to make optional/required field modifiers compulsory

2017-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-455: -- Priority: Minor (was: Major) Issue Type: Epic (was: New Feature) > Compiler

[jira] [Commented] (THRIFT-455) Compiler flag to make optional/required field modifiers compulsory

2017-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949288#comment-15949288 ] James E. King, III commented on THRIFT-455: --- THRIFT-4126 presents a php implementation change

[jira] [Commented] (THRIFT-4062) Remove debug print from TServiceClient

2017-03-30 Thread Vladyslav Valt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948452#comment-15948452 ] Vladyslav Valt commented on THRIFT-4062: [~jking3] thank you, James! > Remove debug print from

[jira] [Comment Edited] (THRIFT-4062) Remove debug print from TServiceClient

2017-03-30 Thread Vladyslav Valt (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948452#comment-15948452 ] Vladyslav Valt edited comment on THRIFT-4062 at 3/30/17 5:46 AM: -