[GitHub] thrift pull request #1397: change DOCKER_ env vars for travis integration to...

GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1397 change DOCKER_ env vars for travis integration to work better and enable hub images for official PR builds You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (THRIFT-4306) Thrift imports not replicated to D service output

[ https://issues.apache.org/jira/browse/THRIFT-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213974#comment-16213974 ] ASF GitHub Bot commented on THRIFT-4306: GitHub user dhasenan opened a pull request:

[jira] [Commented] (THRIFT-4305) Emit ddoc for generated items

[ https://issues.apache.org/jira/browse/THRIFT-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213975#comment-16213975 ] ASF GitHub Bot commented on THRIFT-4305: GitHub user dhasenan opened a pull request:

[GitHub] thrift pull request #1396: THRIFT-4305 Doc comments in dlang output

GitHub user dhasenan opened a pull request: https://github.com/apache/thrift/pull/1396 THRIFT-4305 Doc comments in dlang output Thrift IDL supports documentation comments. D supports doc comments. So let's copy them over! Future directions: add function parameter docs.

[GitHub] thrift pull request #1395: THRIFT-4306 dlang: public imports for dependencie...

GitHub user dhasenan opened a pull request: https://github.com/apache/thrift/pull/1395 THRIFT-4306 dlang: public imports for dependencies If you have an IDL file that imports another IDL file, you can define a service that accepts, yields, or throws types defined in the

[GitHub] thrift pull request #1391: Fix segment fault at thrift_protocol extension

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1391#discussion_r146107107 --- Diff: lib/php/src/ext/thrift_protocol/config.m4 --- @@ -1,25 +1,27 @@ -dnl Copyright (C) 2009 Facebook -dnl Copying and distribution of this

[GitHub] thrift issue #1391: Fix segment fault at thrift_protocol extension

Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1391 Hi, about license. `Copyright (C) 2009 Facebook` at file `lib/php/src/ext/thrift_protocol/config.m4` was add by commit f82aee5087bd62989482f5c532cbd80f97a39b7f. But before this

[GitHub] thrift issue #1391: Fix segment fault at thrift_protocol extension

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1391 @jfarrell I see licensing changes in this pull request, can you review? ---

[jira] [Updated] (THRIFT-4366) upgrade to 0.10 CPP ,when readMessageBegin coredump

[ https://issues.apache.org/jira/browse/THRIFT-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaomingzhongguo updated THRIFT-4366: - Priority: Critical (was: Major) > upgrade to 0.10 CPP ,when readMessageBegin coredump