[jira] [Comment Edited] (THRIFT-3877) C++: library don't work with HTTP (csharp server, cpp client; need cross test enhancement)

[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277868#comment-16277868 ] Chet Murthy edited comment on THRIFT-3877 at 12/5/17 3:07 AM: -- James, wait,

Re: [VOTE] Apache Thrift 0.11.0-rc0 release candidate

+1 On Sun, Dec 3, 2017 at 12:18 PM, Jens Geyer wrote: > Hi all, > > I propose that we accept the following release candidate as the official > Apache Thrift 0.11.0 release. > > https://dist.apache.org/repos/dist/dev/thrift/0.11.0-rc0/ > thrift-0.11.0-rc0.tar.gz > > The

[jira] [Comment Edited] (THRIFT-3877) C++: library don't work with HTTP (csharp server, cpp client; need cross test enhancement)

[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277868#comment-16277868 ] Chet Murthy edited comment on THRIFT-3877 at 12/5/17 1:28 AM: -- James, wait,

[jira] [Commented] (THRIFT-3877) C++: library don't work with HTTP (csharp server, cpp client; need cross test enhancement)

[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277868#comment-16277868 ] Chet Murthy commented on THRIFT-3877: - James, wait, I'm not sure you want that. (1) first, to echo

[jira] [Commented] (THRIFT-3877) C++: library don't work with HTTP (csharp server, cpp client; need cross test enhancement)

[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277860#comment-16277860 ] James E. King, III commented on THRIFT-3877: That seems reasonable; we need to maintain

[jira] [Commented] (THRIFT-3877) C++: library don't work with HTTP (csharp server, cpp client; need cross test enhancement)

[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277831#comment-16277831 ] Chet Murthy commented on THRIFT-3877: - Jens, I agree 100%. What we're looking for is a response of

[jira] [Comment Edited] (THRIFT-3877) C++: library don't work with HTTP (csharp server, cpp client; need cross test enhancement)

[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277814#comment-16277814 ] Jens Geyer edited comment on THRIFT-3877 at 12/5/17 12:40 AM: -- @Chet: The

[jira] [Commented] (THRIFT-3877) C++: library don't work with HTTP (csharp server, cpp client; need cross test enhancement)

[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277814#comment-16277814 ] Jens Geyer commented on THRIFT-3877: @Chet: The fact that HTTP always needs a response does not imply

[jira] [Commented] (THRIFT-3877) C++: library don't work with HTTP (csharp server, cpp client; need cross test enhancement)

[ https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277798#comment-16277798 ] Chet Murthy commented on THRIFT-3877: - James, I'm at an impasse on this PR. I have neither

[jira] [Updated] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen

[ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4403: --- Fix Version/s: (was: 0.11.0) 0.12.0 > thrift.js: Incorrect usage of 'this' in

[jira] [Updated] (THRIFT-4405) Proper use of sequence IDs in all clients and servers

[ https://issues.apache.org/jira/browse/THRIFT-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4405: --- Summary: Proper use of sequence IDs in all clients and servers (was: Create a

[jira] [Updated] (THRIFT-4405) Create a feature test that verifies sequence numbers are used properly and fix problems that are discovered

[ https://issues.apache.org/jira/browse/THRIFT-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4405: --- Description: Create a feature test that verifies sequence numbers are used properly.

[jira] [Commented] (THRIFT-4373) Extending Thrift class results in "Attempt serialize from non-Thrift object"

[ https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277464#comment-16277464 ] ASF GitHub Bot commented on THRIFT-4373: Github user james-johnston-thumbtack commented on the

[jira] [Updated] (THRIFT-4405) Create a feature test that verifies sequence numbers are used properly and fix problems that are discovered

[ https://issues.apache.org/jira/browse/THRIFT-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4405: --- Description: Create a feature test that verifies sequence numbers are used properly.

[jira] [Updated] (THRIFT-4405) Create a feature test that verifies sequence numbers are used properly and fix problems that are discovered

[ https://issues.apache.org/jira/browse/THRIFT-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4405: --- Description: Create a feature test that verifies sequence numbers are used properly.

[jira] [Updated] (THRIFT-4405) Create a feature test that verifies sequence numbers are used properly and fix problems that are discovered

[ https://issues.apache.org/jira/browse/THRIFT-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4405: --- Summary: Create a feature test that verifies sequence numbers are used properly and

[jira] [Updated] (THRIFT-4405) Create a feature test that verifies sequence numbers are used properly

[ https://issues.apache.org/jira/browse/THRIFT-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4405: --- Description: Create a feature test that verifies sequence numbers are used properly.

[jira] [Updated] (THRIFT-4405) Create a feature test that verifies sequence numbers are used properly

[ https://issues.apache.org/jira/browse/THRIFT-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4405: --- Summary: Create a feature test that verifies sequence numbers are used properly

[jira] [Created] (THRIFT-4405) Create a functional test that verifies sequence numbers are used properly

James E. King, III created THRIFT-4405: -- Summary: Create a functional test that verifies sequence numbers are used properly Key: THRIFT-4405 URL: https://issues.apache.org/jira/browse/THRIFT-4405

[jira] [Commented] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen

[ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276991#comment-16276991 ] ASF GitHub Bot commented on THRIFT-4403: Github user asfgit closed the pull request at:

[jira] [Resolved] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen

[ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4403. Resolution: Fixed Fix Version/s: 0.11.0 Committed - thanks! > thrift.js:

[GitHub] thrift pull request #1437: THRIFT-4403: Fix incorrect usage of 'this'

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1437 ---

[jira] [Assigned] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen

[ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4403: -- Assignee: James E. King, III > thrift.js: Incorrect usage of 'this' in

[GitHub] thrift pull request #1437: THRIFT-4403: Fix incorrect usage of 'this'

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1437#discussion_r154679526 --- Diff: lib/js/src/thrift.js --- @@ -599,8 +599,8 @@ Thrift.TWebSocketTransport.prototype = { //If the user made calls before the

[jira] [Commented] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen

[ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276906#comment-16276906 ] ASF GitHub Bot commented on THRIFT-4403: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1437: THRIFT-4403: Fix incorrect usage of 'this'

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1437#discussion_r154672797 --- Diff: lib/js/src/thrift.js --- @@ -599,8 +599,8 @@ Thrift.TWebSocketTransport.prototype = { //If the user made calls before the

[jira] [Commented] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen

[ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276902#comment-16276902 ] ASF GitHub Bot commented on THRIFT-4403: Github user jeking3 commented on a diff in the pull

[jira] [Created] (THRIFT-4404) Is TSSLSocket is thred-safe in thift version 0.9.3?

leyu zhu created THRIFT-4404: Summary: Is TSSLSocket is thred-safe in thift version 0.9.3? Key: THRIFT-4404 URL: https://issues.apache.org/jira/browse/THRIFT-4404 Project: Thrift Issue Type:

[GitHub] thrift pull request #1437: THRIFT-4403: Fix incorrect usage of 'this'

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1437#discussion_r154672290 --- Diff: lib/js/src/thrift.js --- @@ -599,8 +599,8 @@ Thrift.TWebSocketTransport.prototype = { //If the user made calls before the

[jira] [Commented] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen

[ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276885#comment-16276885 ] ASF GitHub Bot commented on THRIFT-4403: Github user bananer commented on a diff in the pull

[GitHub] thrift pull request #1437: THRIFT-4403: Fix incorrect usage of 'this'

Github user bananer commented on a diff in the pull request: https://github.com/apache/thrift/pull/1437#discussion_r154668539 --- Diff: lib/js/src/thrift.js --- @@ -599,8 +599,8 @@ Thrift.TWebSocketTransport.prototype = { //If the user made calls before the

[jira] [Commented] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen

[ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276874#comment-16276874 ] ASF GitHub Bot commented on THRIFT-4403: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1437: THRIFT-4403: Fix incorrect usage of 'this'

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1437#discussion_r154666904 --- Diff: lib/js/src/thrift.js --- @@ -599,8 +599,8 @@ Thrift.TWebSocketTransport.prototype = { //If the user made calls before the

[jira] [Commented] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen

[ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276857#comment-16276857 ] ASF GitHub Bot commented on THRIFT-4403: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1437: THRIFT-4403: Fix incorrect usage of 'this'

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1437 Great - I am going to see if this resolves any of the cross test known failures. ---

[jira] [Updated] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen

[ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Frank updated THRIFT-4403: - Component/s: JavaScript - Library > thrift.js: Incorrect usage of 'this' in

[jira] [Commented] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen

[ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276714#comment-16276714 ] Philip Frank commented on THRIFT-4403: -- Fix: https://github.com/apache/thrift/pull/1437 >

[jira] [Commented] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen

[ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276713#comment-16276713 ] ASF GitHub Bot commented on THRIFT-4403: GitHub user bananer opened a pull request:

[GitHub] thrift pull request #1437: THRIFT-4403: Fix incorrect usage of 'this'

GitHub user bananer opened a pull request: https://github.com/apache/thrift/pull/1437 THRIFT-4403: Fix incorrect usage of 'this' You can merge this pull request into a Git repository by running: $ git pull https://github.com/bananer/thrift THRIFT-4403 Alternatively you can

[jira] [Created] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen

Philip Frank created THRIFT-4403: Summary: thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen Key: THRIFT-4403 URL: https://issues.apache.org/jira/browse/THRIFT-4403 Project: Thrift