I would be happy to port tests from boost-test to googletest -- and in the
process, we could arrange for running tests in parallel, e.g. the
cross-test. I've found that googetest is much more . helpful for
debugging. I'd also vote for (in the C++ code) putting in glog support,
for similar
The main source of work on the Thrift side will be porting the tests. Many
of them are based on boost test right now.
I'm generally fine with the idea, just be aware that this is a breaking
change, though the break will often be easily dealt with by users
(replacing std with boost).
If you want
A pull request was submitted recently that is a work in progress to move
away from Boost. This is something the team has expressed a desire for in
the past (although as a maintainer of two boost libraries it makes me sad!)
as will will reduce project dependencies.
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1448#discussion_r158557742
--- Diff: lib/cpp/src/thrift/processor/TMultiplexedProcessor.h ---
@@ -165,10 +166,11 @@ class TMultiplexedProcessor : public TProcessor {
}
[
https://issues.apache.org/jira/browse/THRIFT-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301890#comment-16301890
]
Christopher Tubbs commented on THRIFT-4413:
---
[~jking3] That is incorrect. Any committer/PMC
[
https://issues.apache.org/jira/browse/THRIFT-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4413:
---
Affects Version/s: 0.11.0
> Publish a Maven artifact for Thrift v0.11
>
[
https://issues.apache.org/jira/browse/THRIFT-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301820#comment-16301820
]
James E. King, III commented on THRIFT-4413:
I'm not certain of this but I believe only
[
https://issues.apache.org/jira/browse/THRIFT-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301734#comment-16301734
]
Buğra Gedik commented on THRIFT-4413:
-
[~jking3] Hi James, since it is impossible to get any response
GitHub user Typz opened a pull request:
https://github.com/apache/thrift/pull/1448
[WIP] Support compilation without Boost
The goal of this series of patches is to support compiling Thrift library
without boost: in C++11, most of the things are already integrated, and it is
often
[
https://issues.apache.org/jira/browse/THRIFT-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301423#comment-16301423
]
Ashenp commented on THRIFT-4432:
I compiled it with php options : nsglobal and oop.
I will try other
[
https://issues.apache.org/jira/browse/THRIFT-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301354#comment-16301354
]
James E. King, III commented on THRIFT-4432:
I don't use PHP regularly enough to answer well,
[
https://issues.apache.org/jira/browse/THRIFT-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4432:
---
Issue Type: Question (was: Bug)
> thrift compiler changed my struct'name
>
[
https://issues.apache.org/jira/browse/THRIFT-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III closed THRIFT-4380.
--
Assignee: James E. King, III
> Compiler incorrect generates code which treats a Java
[
https://issues.apache.org/jira/browse/THRIFT-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4433:
---
Component/s: (was: Python - Compiler)
Python - Library
> the
[
https://issues.apache.org/jira/browse/THRIFT-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301331#comment-16301331
]
James E. King, III commented on THRIFT-4433:
Does this happen on 0.10.0 or 0.11.0?
Version
[
https://issues.apache.org/jira/browse/THRIFT-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301297#comment-16301297
]
Ashenp commented on THRIFT-4432:
Does anyone could explain this issue?
> thrift compiler changed my
yuezhang created THRIFT-4433:
Summary: the response is the responce of last request after socket
errorno:4
Key: THRIFT-4433
URL: https://issues.apache.org/jira/browse/THRIFT-4433
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashenp updated THRIFT-4432:
---
Component/s: PHP - Compiler
> thrift compiler changed my struct'name
>
[
https://issues.apache.org/jira/browse/THRIFT-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashenp updated THRIFT-4432:
---
Description:
I defined a struct in thrift file with underlined name:
struct invite_record_change {
1:
Ashenp created THRIFT-4432:
--
Summary: thrift compiler changed my struct'name
Key: THRIFT-4432
URL: https://issues.apache.org/jira/browse/THRIFT-4432
Project: Thrift
Issue Type: Bug
Affects
20 matches
Mail list logo