[jira] [Commented] (THRIFT-4464) Potentially server-crashing typo in Python TNonblockingServer

2018-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331864#comment-16331864 ] ASF GitHub Bot commented on THRIFT-4464: GitHub user tomtung opened a pull request:

[GitHub] thrift pull request #1475: THRIFT-4464: Fix typo in TNonblockingServer.py

2018-01-18 Thread tomtung
GitHub user tomtung opened a pull request: https://github.com/apache/thrift/pull/1475 THRIFT-4464: Fix typo in TNonblockingServer.py You can merge this pull request into a Git repository by running: $ git pull https://github.com/tomtung/thrift patch-2 Alternatively you can

Re: Is the Thrift serialization compatible both directions?

2018-01-18 Thread Randy Abernethy
Taking this apart: - Any new fields that you add should be optional. I disagree, default requiredness with a default value works fine as well (and is my preference if you are not interested in optimizing the field away in procs that know about it). On the server side,if the default field is there

Is the Thrift serialization compatible both directions?

2018-01-18 Thread Jean Rodier
Hi, Is this statement true, especially the last part? (from: https://diwakergupta.github.io/thrift-missing-guide/) Any new fields that you add should be optional. This means that any messages serialized by code using your "old" message format can be parsed by your new generated code, as

[GitHub] thrift issue #1468: Thrift 4259: Thrift does not compile due to Ant Maven ta...

2018-01-18 Thread Alex-Vol
Github user Alex-Vol commented on the issue: https://github.com/apache/thrift/pull/1468 I really hope AppVeyor works now. For some reason the CMakeLists.txt in Java had an implicit dependency on the compiler but did not have a target dependency declaration. The new build requires the

Is the Thrift serialization compatible both directions?

2018-01-18 Thread Jean Rodier
Hi, Is this statement true, especially the last part? Any new fields that you add should be optional. This means that any messages serialized by code using your "old" message format can be parsed by your new generated code, as they won’t be missing any required elements. Similarly, messages

Is the Thrift serialization compatible both directions?

2018-01-18 Thread Jean Rodier
Hi, Is this statement true, especially the last part? (from: https://diwakergupta.github.io/thrift-missing-guide/) Any new fields that you add should be optional. This means that any messages serialized by code using your "old" message format can be parsed by your new generated code, as they

[GitHub] thrift issue #1380: Support x64 build mode on Windows with DMD v2.076.0.

2018-01-18 Thread Heromyth
Github user Heromyth commented on the issue: https://github.com/apache/thrift/pull/1380 1) Merged with the latest Thrift code. 2) Tested with DMD 2.078 on Linux Mint 18.3 3) All unittests are passed and all tests run succesfully. ---