Re: lib/nodets and lib/ts

2019-01-09 Thread Brian Forbis
Not the author of that new code, but the typescript code in lib/nodets is not actually a library implementation, just a suite of tests. The original JS compiler implementation with TypeScript support did not support the nodejs compiler switch, which mean generated thrift code in TypeScript would

Re: Branch history fixups

2019-01-09 Thread James E. King III
It is not uncommon to either cherry-pick a critical fix from master back into a release branch, or to make a packaging related change to fix language-specific packaging metadata and do it in the branch. All release branches should merge back into master even if they drop the version number changes

[jira] [Commented] (THRIFT-4675) JS code generators not handling int64 type properly for constants and for TypeScript type mappings

2019-01-09 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738194#comment-16738194 ] James E. King III commented on THRIFT-4675: --- So this affects lib/ts and not li

AW: Branch history fixups

2019-01-09 Thread Jens Geyer
Why are there code changes in the brznch in the first place? Sent from mobile device, please ignore spelling mistakes. Von: James E. King III Gesendet: 08.01.2019 16:33 An: dev@thrift.apache.org Betreff: Branch history fixups Our release branching strategy has lef