Re: [DISCUSSION] JIRA-Tickets vs. Patches & Pull Requests

2019-02-17 Thread James E. King III
I don't think a ticket per pull request is appropriate for things like typos, modifications to documentation, simple modifications to the CI environment, or to code comments. For example if I move the bionic build jobs from go 1.11.4 to 1.11.5, that should not require a ticket. It's just noise in

[jira] [Commented] (THRIFT-4806) Convert NodeJS Library to typescript

2019-02-17 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770473#comment-16770473 ] James E. King III commented on THRIFT-4806: --- Simplification is good, and people have past

[jira] [Resolved] (THRIFT-4024) Skip() should throw on unknown data types

2019-02-17 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III resolved THRIFT-4024. --- Resolution: Fixed Fix Version/s: 0.13.0 Resolving as fixed in 0.13.0, all

[jira] [Commented] (THRIFT-4677) UnicodeDecodeError in Python3

2019-02-17 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770468#comment-16770468 ] James E. King III commented on THRIFT-4677: --- Would you be able to post at least a stack trace?

[jira] [Commented] (THRIFT-4677) UnicodeDecodeError in Python3

2019-02-17 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770412#comment-16770412 ] Aki Sukegawa commented on THRIFT-4677: -- AFAIK Apache Thrift's string wire format is tied to UTF8.

[jira] [Resolved] (THRIFT-4056) Skip() should throw TProtocolException.INVALID_DATA on unknown data types

2019-02-17 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-4056. -- Resolution: Not A Problem It doesn't throw INVALID_DATA but it correctly aborts the

[jira] [Commented] (THRIFT-4056) Skip() should throw TProtocolException.INVALID_DATA on unknown data types

2019-02-17 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770407#comment-16770407 ] Aki Sukegawa commented on THRIFT-4056: -- The title says "should throw