[jira] [Comment Edited] (THRIFT-5173) Thrift C# (netstd) code generator: make method virtual for mocking

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079981#comment-17079981 ] Jens Geyer edited comment on THRIFT-5173 at 4/9/20, 8:21 PM: - When you ask

[jira] [Commented] (THRIFT-5173) Thrift C# (netstd) code generator: make method virtual for mocking

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079981#comment-17079981 ] Jens Geyer commented on THRIFT-5173: When you ask "why" then that is the exact reason I want you to

[jira] [Resolved] (THRIFT-5166) D: Add WebSocket Server Transport

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5166. Resolution: Fixed > D: Add WebSocket Server Transport > - > >

[jira] [Updated] (THRIFT-5166) Add WebSocket Server Transport

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5166: --- Summary: Add WebSocket Server Transport (was: D: Add WebSocket Server Transport) > Add WebSocket

[jira] [Commented] (THRIFT-5172) NetStd OutOfMemoryException

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079959#comment-17079959 ] Jens Geyer commented on THRIFT-5172: Good catch! > NetStd OutOfMemoryException >

[jira] [Resolved] (THRIFT-5172) NetStd OutOfMemoryException

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5172. Fix Version/s: 0.14.0 Assignee: Eric Bléher Resolution: Fixed > NetStd

[jira] [Comment Edited] (THRIFT-5169) Improve dotnet project files for the .NET Standard build, and integrate with cmake

2020-04-09 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079039#comment-17079039 ] Mario Emmenlauer edited comment on THRIFT-5169 at 4/9/20, 2:48 PM: ---

[jira] [Commented] (THRIFT-5172) NetStd OutOfMemoryException

2020-04-09 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079110#comment-17079110 ] Eric Bléher commented on THRIFT-5172: - Looking further in some TTransport implementations, the Open

[jira] [Comment Edited] (THRIFT-5173) Thrift C# (netstd) code generator: make method virtual for mocking

2020-04-09 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079105#comment-17079105 ] Eric Bléher edited comment on THRIFT-5173 at 4/9/20, 9:30 AM: -- why having a

[jira] [Commented] (THRIFT-5173) Thrift C# (netstd) code generator: make method virtual for mocking

2020-04-09 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079105#comment-17079105 ] Eric Bléher commented on THRIFT-5173: - why having a method virtual would impact performance? >

[jira] [Updated] (THRIFT-5174) In py module, compilation fails when using cmake to execute make

2020-04-09 Thread Zezeng Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zezeng Wang updated THRIFT-5174: Description: In the py module, the compilation fails when using cmake to execute make, but using

[jira] [Created] (THRIFT-5174) In py module, compilation fails when using cmake to execute make

2020-04-09 Thread Zezeng Wang (Jira)
Zezeng Wang created THRIFT-5174: --- Summary: In py module, compilation fails when using cmake to execute make Key: THRIFT-5174 URL: https://issues.apache.org/jira/browse/THRIFT-5174 Project: Thrift

[jira] [Commented] (THRIFT-5169) Improve dotnet project files for the .NET Standard build, and integrate with cmake

2020-04-09 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079039#comment-17079039 ] Mario Emmenlauer commented on THRIFT-5169: -- And I still think its better to fail in the above

[jira] [Commented] (THRIFT-5169) Improve dotnet project files for the .NET Standard build, and integrate with cmake

2020-04-09 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079009#comment-17079009 ] Mario Emmenlauer commented on THRIFT-5169: -- > The version if the compiler should always match

[jira] [Commented] (THRIFT-5173) Thrift C# (netstd) code generator: make method virtual for mocking

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079007#comment-17079007 ] Jens Geyer commented on THRIFT-5173: Make sure you check the impact on performance when implemening

[jira] [Commented] (THRIFT-5172) NetStd OutOfMemoryException

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079006#comment-17079006 ] Jens Geyer commented on THRIFT-5172: A transport should not be able to be opened multiple times

[jira] [Comment Edited] (THRIFT-5172) NetStd OutOfMemoryException

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079006#comment-17079006 ] Jens Geyer edited comment on THRIFT-5172 at 4/9/20, 7:23 AM: - A transport

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-09 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079004#comment-17079004 ] Mario Emmenlauer commented on THRIFT-5109: -- I may need help with a small issue, or otherwise

[jira] [Commented] (THRIFT-5169) Improve dotnet project files for the .NET Standard build, and integrate with cmake

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079002#comment-17079002 ] Jens Geyer commented on THRIFT-5169: The version if the compiler should always match the library

[jira] [Commented] (THRIFT-4833) warning CS0114 "Xception.Message" hides inherited member "Exception.Message"

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079000#comment-17079000 ] Jens Geyer commented on THRIFT-4833: Probably, yes. > warning CS0114 "Xception.Message" hides

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078998#comment-17078998 ] Jens Geyer commented on THRIFT-5109: {quote} And would you like all commits in a single PR, or split

[jira] [Comment Edited] (THRIFT-5109) Misc CMake improvements

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078998#comment-17078998 ] Jens Geyer edited comment on THRIFT-5109 at 4/9/20, 7:17 AM: - {quote} And

[jira] [Assigned] (THRIFT-5168) Useless generated code when .thrift file only has service type

2020-04-09 Thread Zezeng Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zezeng Wang reassigned THRIFT-5168: --- Assignee: Zezeng Wang > Useless generated code when .thrift file only has service type >