[GitHub] [thrift] MikaelSmith opened a new pull request, #2620: THRIFT-5595: Avoid peek request with SSLSocket

2022-06-08 Thread GitBox
MikaelSmith opened a new pull request, #2620: URL: https://github.com/apache/thrift/pull/2620 Overrides isOpen on TSSLSocket to preserve old implementation that doesn't attempt to peek on recv. The update to TSocket in 01d53f483a7531ad4899b522060e8913dca309fb errors for TSSLSocket

[jira] [Commented] (THRIFT-5595) TSocket errors with SSLSocket

2022-06-08 Thread Michael Smith (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551813#comment-17551813 ] Michael Smith commented on THRIFT-5595: --- I can probably look at fixing this next week, if not

[jira] [Comment Edited] (THRIFT-5595) TSocket errors with SSLSocket

2022-06-08 Thread Michael Smith (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551813#comment-17551813 ] Michael Smith edited comment on THRIFT-5595 at 6/8/22 10:28 PM: I can

[jira] [Commented] (THRIFT-5595) TSocket errors with SSLSocket

2022-06-08 Thread Michael Smith (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551806#comment-17551806 ] Michael Smith commented on THRIFT-5595: --- We're using this to test if it's safe to `close` the

[jira] [Commented] (THRIFT-5595) TSocket errors with SSLSocket

2022-06-08 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551805#comment-17551805 ] Yuxuan Wang commented on THRIFT-5595: - hmm it looks like python does have this restriction for

[jira] [Updated] (THRIFT-5595) TSocket errors with SSLSocket

2022-06-08 Thread Michael Smith (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Smith updated THRIFT-5595: -- Description: Starting with 0.14.0 - probably

[jira] [Created] (THRIFT-5595) TSocket errors with SSLSocket

2022-06-08 Thread Michael Smith (Jira)
Michael Smith created THRIFT-5595: - Summary: TSocket errors with SSLSocket Key: THRIFT-5595 URL: https://issues.apache.org/jira/browse/THRIFT-5595 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-08 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551776#comment-17551776 ] Jens Geyer commented on THRIFT-5587: {quote}Should the related PR (doc, other languages) be on the

[jira] [Commented] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-08 Thread Triton Circonflexe (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551770#comment-17551770 ] Triton Circonflexe commented on THRIFT-5587: If any wireshark capture (binary and/or compact

[GitHub] [thrift] nanreh opened a new pull request, #2619: THRIFT-4086: Add missing calls to get_true_type when generating valid…

2022-06-08 Thread GitBox
nanreh opened a new pull request, #2619: URL: https://github.com/apache/thrift/pull/2619 …ator + metadata code Client: java The change is trivial: just added a couple of missing calls to `get_true_type` in the Java generator so that we get exactly the same code regardless of

[jira] [Resolved] (THRIFT-5592) Update documentation and IDL definition files for uuid type

2022-06-08 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5592. Fix Version/s: 0.17.0 Resolution: Fixed > Update documentation and IDL definition files

[GitHub] [thrift] Jens-G closed pull request #2618: THRIFT-5592 Add uuid type documentation

2022-06-08 Thread GitBox
Jens-G closed pull request #2618: THRIFT-5592 Add uuid type documentation URL: https://github.com/apache/thrift/pull/2618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-08 Thread Triton Circonflexe (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551525#comment-17551525 ] Triton Circonflexe commented on THRIFT-5587: Should the related PR (doc, other languages) be

[jira] [Commented] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-08 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551420#comment-17551420 ] Jens Geyer commented on THRIFT-5587: Fighting CI vis-á-vis a partial implementation of this feature