[jira] [Closed] (THRIFT-5790) Thrift headers raise compiler warnings on MSVC

2024-05-31 Thread Carel (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carel closed THRIFT-5790. - Resolution: Invalid I see this was already fixed We are still using Thrift 0.17 and this was fixed in 0.19

[jira] [Commented] (THRIFT-5790) Thrift headers raise compiler warnings on MSVC

2024-05-31 Thread Carel (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850938#comment-17850938 ] Carel commented on THRIFT-5790: --- I will make a PR for this hopefully over the weekend, for now just making

[jira] [Commented] (THRIFT-5790) Thrift headers raise compiler warnings on MSVC

2024-05-31 Thread Carel (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850937#comment-17850937 ] Carel commented on THRIFT-5790: --- I also have notes of this warning happening but I suspect it does respect

[jira] [Updated] (THRIFT-5790) Thrift headers raise compiler warnings on MSVC

2024-05-31 Thread Carel (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carel updated THRIFT-5790: -- Description: When building a C++ application using MSVC (2019) the following warnings are raised:

[jira] [Created] (THRIFT-5790) Thrift headers raise compiler warnings on MSVC

2024-05-31 Thread Carel (Jira)
Carel created THRIFT-5790: - Summary: Thrift headers raise compiler warnings on MSVC Key: THRIFT-5790 URL: https://issues.apache.org/jira/browse/THRIFT-5790 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-5773) UUID wrapper for C++

2024-05-31 Thread Carel (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850913#comment-17850913 ] Carel commented on THRIFT-5773: --- [~Triton] [~jensg]  Any feedback on this? I am still not sure how to