[jira] [Created] (THRIFT-2263) Always generate good hashCode for Java

2013-11-16 Thread Andrew Gaul (JIRA)
Andrew Gaul created THRIFT-2263: --- Summary: Always generate good hashCode for Java Key: THRIFT-2263 URL: https://issues.apache.org/jira/browse/THRIFT-2263 Project: Thrift Issue Type

[jira] [Updated] (THRIFT-2263) Always generate good hashCode for Java

2013-11-16 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated THRIFT-2263: Attachment: THRIFT-2263.patch Pull request also available at: https://github.com/apache/thrift

[jira] [Commented] (THRIFT-2218) Make java TSerializer and TDeserializer thread safe

2013-11-16 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824768#comment-13824768 ] Andrew Gaul commented on THRIFT-2218: - What advantages does storing TSerializer

introduction from Maginatics

2013-11-11 Thread Andrew Gaul
to continuing to work together! -- Andrew Gaul http://maginatics.com/

[jira] [Updated] (THRIFT-1813) Add @Generated annotation to generated classes

2013-11-04 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated THRIFT-1813: Attachment: THRIFT-1813.patch [~roger.meier] I rebased Arvind's patch, removed the duplication

[jira] [Commented] (THRIFT-2122) NPE in TSSLTransportFactory.createClient when no truststore password is passed in custom SSL params

2013-10-28 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806977#comment-13806977 ] Andrew Gaul commented on THRIFT-2122: - +1, KeyStoreSpi.engineLoad specifies null

[jira] [Created] (THRIFT-2238) Add option to store binary data as byte[] instead of ByteBuffer

2013-10-23 Thread Andrew Gaul (JIRA)
Andrew Gaul created THRIFT-2238: --- Summary: Add option to store binary data as byte[] instead of ByteBuffer Key: THRIFT-2238 URL: https://issues.apache.org/jira/browse/THRIFT-2238 Project: Thrift

[jira] [Updated] (THRIFT-2238) Add option to store binary data as byte[] instead of ByteBuffer

2013-10-23 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated THRIFT-2238: Description: My Java application stores many Thrift structs in-memory with small binary fields

[jira] [Commented] (THRIFT-1813) Add @Generated annotation to generated classes

2013-10-23 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13803661#comment-13803661 ] Andrew Gaul commented on THRIFT-1813: - +1, should we also include the date? http

[jira] [Created] (THRIFT-2239) Address FindBugs errors

2013-10-23 Thread Andrew Gaul (JIRA)
Andrew Gaul created THRIFT-2239: --- Summary: Address FindBugs errors Key: THRIFT-2239 URL: https://issues.apache.org/jira/browse/THRIFT-2239 Project: Thrift Issue Type: Improvement

[jira] [Updated] (THRIFT-2239) Address FindBugs errors

2013-10-23 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated THRIFT-2239: Attachment: THRIFT-2239.patch GitHub pull request available at: https://github.com/apache/thrift

[jira] [Created] (THRIFT-2233) Java compiler should defensively copy its binary inputs

2013-10-22 Thread Andrew Gaul (JIRA)
Andrew Gaul created THRIFT-2233: --- Summary: Java compiler should defensively copy its binary inputs Key: THRIFT-2233 URL: https://issues.apache.org/jira/browse/THRIFT-2233 Project: Thrift Issue

[jira] [Updated] (THRIFT-2233) Java compiler should defensively copy its binary inputs

2013-10-22 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated THRIFT-2233: Attachment: THRIFT-2233.patch Pull request available at: https://github.com/apache/thrift/pull

[jira] [Commented] (THRIFT-2172) Java compiler allocates optionals array for every struct with an optional field

2013-10-22 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801524#comment-13801524 ] Andrew Gaul commented on THRIFT-2172: - Any comments on this issue? Java compiler

Re: thrift pull request: Defensively copy binary fields (THRIFT-2233)

2013-10-22 Thread Andrew Gaul
at: https://github.com/apache/thrift/pull/60.patch commit 5f7545b1dcd0d94724bc41cfb41bef0d7d4c869d Author: Andrew Gaul g...@maginatics.com Date: 2013-10-22T00:38:15Z Defensively copy binary fields (THRIFT-2233) This ensures that one consumer of a ByteBuffer does

[jira] [Created] (THRIFT-2227) Thrift compiler generates spurious warnings with Xlint

2013-10-14 Thread Andrew Gaul (JIRA)
Andrew Gaul created THRIFT-2227: --- Summary: Thrift compiler generates spurious warnings with Xlint Key: THRIFT-2227 URL: https://issues.apache.org/jira/browse/THRIFT-2227 Project: Thrift Issue

[jira] [Created] (THRIFT-2193) Java code generator emits spurious semicolon when deep copying binary data

2013-09-18 Thread Andrew Gaul (JIRA)
Andrew Gaul created THRIFT-2193: --- Summary: Java code generator emits spurious semicolon when deep copying binary data Key: THRIFT-2193 URL: https://issues.apache.org/jira/browse/THRIFT-2193 Project

[jira] [Updated] (THRIFT-2172) Java compiler allocates optionals array for every struct with an optional field

2013-09-18 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated THRIFT-2172: Patch Info: Patch Available Java compiler allocates optionals array for every struct

[jira] [Updated] (THRIFT-2193) Java code generator emits spurious semicolon when deep copying binary data

2013-09-18 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated THRIFT-2193: Attachment: THRIFT-2193.patch Java code generator emits spurious semicolon when deep copying

[jira] [Updated] (THRIFT-2193) Java code generator emits spurious semicolon when deep copying binary data

2013-09-18 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated THRIFT-2193: Component/s: Java - Compiler Priority: Trivial (was: Major) Affects

[jira] [Commented] (THRIFT-2193) Java code generator emits spurious semicolon when deep copying binary data

2013-09-18 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771298#comment-13771298 ] Andrew Gaul commented on THRIFT-2193: - Pull request at: https://github.com/apache

[jira] [Created] (THRIFT-2172) Java compiler allocates optionals array for every struct with an optional field

2013-09-06 Thread Andrew Gaul (JIRA)
Andrew Gaul created THRIFT-2172: --- Summary: Java compiler allocates optionals array for every struct with an optional field Key: THRIFT-2172 URL: https://issues.apache.org/jira/browse/THRIFT-2172

[jira] [Updated] (THRIFT-2172) Java compiler allocates optionals array for every struct with an optional field

2013-09-06 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated THRIFT-2172: Attachment: THRIFT-2172.patch Pull request at: https://github.com/apache/thrift/pull/52

[jira] [Created] (THRIFT-1818) GitHub mirroring incorrect git repository

2013-01-05 Thread Andrew Gaul (JIRA)
Andrew Gaul created THRIFT-1818: --- Summary: GitHub mirroring incorrect git repository Key: THRIFT-1818 URL: https://issues.apache.org/jira/browse/THRIFT-1818 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-1815) Code generators line buffer output

2013-01-04 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544099#comment-13544099 ] Andrew Gaul commented on THRIFT-1815: - Thanks; attached. Code

[jira] [Updated] (THRIFT-1815) Code generators line buffer output

2013-01-04 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated THRIFT-1815: Attachment: thrift-1815-compiler-line-buffering.patch Code generators line buffer output

[jira] [Commented] (THRIFT-1815) Code generators line buffer output

2013-01-03 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543473#comment-13543473 ] Andrew Gaul commented on THRIFT-1815: - Sorry I did not realize that Thrift moved

[jira] [Updated] (THRIFT-1815) Code generators line buffer output

2013-01-03 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated THRIFT-1815: Attachment: (was: thrift_std_endl.patch) Code generators line buffer output

[jira] [Commented] (THRIFT-1815) Code generators line buffer output

2013-01-01 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541961#comment-13541961 ] Andrew Gaul commented on THRIFT-1815: - 1) I compile 3,500 lines across 11 .thrift

[jira] [Comment Edited] (THRIFT-1815) Code generators line buffer output

2013-01-01 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541961#comment-13541961 ] Andrew Gaul edited comment on THRIFT-1815 at 1/2/13 1:28 AM

[jira] [Comment Edited] (THRIFT-1815) Code generators line buffer output

2013-01-01 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541961#comment-13541961 ] Andrew Gaul edited comment on THRIFT-1815 at 1/2/13 1:38 AM

[jira] [Created] (THRIFT-1817) make install should install versioned binary and symlink to thrift binary

2013-01-01 Thread Andrew Gaul (JIRA)
Andrew Gaul created THRIFT-1817: --- Summary: make install should install versioned binary and symlink to thrift binary Key: THRIFT-1817 URL: https://issues.apache.org/jira/browse/THRIFT-1817 Project

[jira] [Created] (THRIFT-1815) Code generators line buffer output

2012-12-30 Thread Andrew Gaul (JIRA)
Andrew Gaul created THRIFT-1815: --- Summary: Code generators line buffer output Key: THRIFT-1815 URL: https://issues.apache.org/jira/browse/THRIFT-1815 Project: Thrift Issue Type: Bug

[jira] [Created] (THRIFT-1752) structs do not implement Comparable and have a redundant cast

2012-11-11 Thread Andrew Gaul (JIRA)
Andrew Gaul created THRIFT-1752: --- Summary: structs do not implement Comparable and have a redundant cast Key: THRIFT-1752 URL: https://issues.apache.org/jira/browse/THRIFT-1752 Project: Thrift

[jira] [Commented] (THRIFT-872) Add 'primitive' option to 'Java' code generator

2012-02-16 Thread Andrew Gaul (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209549#comment-13209549 ] Andrew Gaul commented on THRIFT-872: Does THRIFT-1469 close this issue