[jira] [Updated] (THRIFT-1567) Thrift/cpp: Allow alternate classes to be used for

[ https://issues.apache.org/jira/browse/THRIFT-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Reiss updated THRIFT-1567: Attachment: thrift-types-demo.patch This is a small demo program I wrote to demonstrate how this c

[jira] [Commented] (THRIFT-1244) using 'using' to disambiguate between functions in different bases does not conform to C++ standard and will not compile on certain compilers

[ https://issues.apache.org/jira/browse/THRIFT-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071945#comment-13071945 ] David Reiss commented on THRIFT-1244: - LGTM, but add a space after the comma to confo

[jira] [Commented] (THRIFT-1191) Erlang binding throws during skipping fields of composite type (maps, lists, structs, sets)

[ https://issues.apache.org/jira/browse/THRIFT-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047491#comment-13047491 ] David Reiss commented on THRIFT-1191: - It looks like skip_field has effectively not b

[jira] [Commented] (THRIFT-1195) Allow users to act on client connects/disconnects

[ https://issues.apache.org/jira/browse/THRIFT-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046275#comment-13046275 ] David Reiss commented on THRIFT-1195: - In C++, the TServerEventHandler and TProcessor

[jira] [Commented] (THRIFT-1115) python TBase class for dynamic (de)serialization, and __slots__ option for memory savings

[ https://issues.apache.org/jira/browse/THRIFT-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039471#comment-13039471 ] David Reiss commented on THRIFT-1115: - {noformat} class First(object): def go(self,

[jira] [Commented] (THRIFT-1115) python TBase class for dynamic (de)serialization, and __slots__ option for memory savings

[ https://issues.apache.org/jira/browse/THRIFT-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038066#comment-13038066 ] David Reiss commented on THRIFT-1115: - Looks solid. Mostly style changes. Does dyn

[jira] [Commented] (THRIFT-1153) HttpClient does not specify the connection close parameter

[ https://issues.apache.org/jira/browse/THRIFT-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022909#comment-13022909 ] David Reiss commented on THRIFT-1153: - I'm confused. We don't want to close the conn

[jira] [Commented] (THRIFT-591) Make the C++ runtime library be compatible with Windows and Visual Studio

[ https://issues.apache.org/jira/browse/THRIFT-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022359#comment-13022359 ] David Reiss commented on THRIFT-591: Yeah. You should just be able to create a TAsioS

[jira] [Commented] (THRIFT-1115) dynamic python object (de)serialization, using __slots__ for less memory, and custom object inheritance

[ https://issues.apache.org/jira/browse/THRIFT-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016091#comment-13016091 ] David Reiss commented on THRIFT-1115: - I think this is a solid design and definitely

[jira] [Commented] (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0

[ https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014174#comment-13014174 ] David Reiss commented on THRIFT-1031: - I agree that that dependency is not acceptable

[jira] [Commented] (THRIFT-1106) C++ code TAsyncProtocolProcessor.h & TAsyncBufferProcessor.h dont have virtual functions but no virtual destructor. Causes warnings on -Wall

[ https://issues.apache.org/jira/browse/THRIFT-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009734#comment-13009734 ] David Reiss commented on THRIFT-1106: - Indentation looks off. Otherwise, looks fine

[jira] [Commented] (THRIFT-1099) TPhpString: serialization/deserialization from string

[ https://issues.apache.org/jira/browse/THRIFT-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009367#comment-13009367 ] David Reiss commented on THRIFT-1099: - How is this different from TMemoryBuffer? > T

[jira] Commented: (THRIFT-627) should c++ have setters for optional fields?

[ https://issues.apache.org/jira/browse/THRIFT-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005216#comment-13005216 ] David Reiss commented on THRIFT-627: The pointers check can be moved outside of the lo

[jira] Commented: (THRIFT-1088) Thrift library python classes should be new-style classes

[ https://issues.apache.org/jira/browse/THRIFT-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004751#comment-13004751 ] David Reiss commented on THRIFT-1088: - No, I meant the generated classes. When the n

[jira] Commented: (THRIFT-1088) Thrift library python classes should be new-style classes

[ https://issues.apache.org/jira/browse/THRIFT-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004696#comment-13004696 ] David Reiss commented on THRIFT-1088: - I guess with and without. Hopefully it won't

[jira] Commented: (THRIFT-1088) Thrift library python classes should be new-style classes

[ https://issues.apache.org/jira/browse/THRIFT-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004660#comment-13004660 ] David Reiss commented on THRIFT-1088: - Can you run a benchmark on this. The reason t

[jira] Commented: (THRIFT-1083) Preforking python process pool server

[ https://issues.apache.org/jira/browse/THRIFT-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004370#comment-13004370 ] David Reiss commented on THRIFT-1083: - Looks fine to me. > Preforking python process

[jira] Commented: (THRIFT-1070) C++ compiler and runtime have 32/64bit problems

[ https://issues.apache.org/jira/browse/THRIFT-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998467#comment-12998467 ] David Reiss commented on THRIFT-1070: - This looks fine. What were the errors and war

[jira] Commented: (THRIFT-151) TSSLServerSocket and TSSLSocket implementation

[ https://issues.apache.org/jira/browse/THRIFT-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998043#comment-12998043 ] David Reiss commented on THRIFT-151: I think the right thing to do in that case is to

[jira] Commented: (THRIFT-1067) Tons of bugs in php implementation

[ https://issues.apache.org/jira/browse/THRIFT-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997942#comment-12997942 ] David Reiss commented on THRIFT-1067: - The original author of the extension module ha

[jira] Commented: (THRIFT-1059) add utf8 coding header to generated file

[ https://issues.apache.org/jira/browse/THRIFT-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994425#comment-12994425 ] David Reiss commented on THRIFT-1059: - I'd rather translate the non-ascii characters

[jira] Commented: (THRIFT-681) The HTML generator does not handle JavaDoc style comments very well

[ https://issues.apache.org/jira/browse/THRIFT-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992087#comment-12992087 ] David Reiss commented on THRIFT-681: My preference is for the latter. I disagree with

[jira] Commented: (THRIFT-1054) explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail

[ https://issues.apache.org/jira/browse/THRIFT-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992084#comment-12992084 ] David Reiss commented on THRIFT-1054: - Fine with me. > explicit call to PKG_PROG_PKG

[jira] Commented: (THRIFT-1048) Thrift java library has redundant dependency on commons-lang.

[ https://issues.apache.org/jira/browse/THRIFT-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987288#action_12987288 ] David Reiss commented on THRIFT-1048: - We still use it for HashCodeBuilder as well if

[jira] Commented: (THRIFT-71) Debian packaging for thrift

[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971020#action_12971020 ] David Reiss commented on THRIFT-71: --- That would be fine with me. > Debian packaging for t

[jira] Commented: (THRIFT-71) Debian packaging for thrift

[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970954#action_12970954 ] David Reiss commented on THRIFT-71: --- bq. I think you're right, the Debian packaging guide

[jira] Commented: (THRIFT-627) should c++ have setters for optional fields?

[ https://issues.apache.org/jira/browse/THRIFT-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969013#action_12969013 ] David Reiss commented on THRIFT-627: No need to generate these at all if "pointers" is

[jira] Commented: (THRIFT-916) gcc warnings in c++ header files

[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934555#action_12934555 ] David Reiss commented on THRIFT-916: CXXFLAGS for C++ and CFLAGS for C. > gcc warnings

[jira] Commented: (THRIFT-916) gcc warnings in c++ header files

[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934550#action_12934550 ] David Reiss commented on THRIFT-916: -Wall should not be in CPPFLAGS. CPPFLAGS is for

[jira] Commented: (THRIFT-252) Python libraries unable to build with MSVC on Windows

[ https://issues.apache.org/jira/browse/THRIFT-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933880#action_12933880 ] David Reiss commented on THRIFT-252: The patch has a lot of \r characters in it. Can y

[jira] Commented: (THRIFT-970) Under heavy load, THttpClient may fail with "too many open files"

[ https://issues.apache.org/jira/browse/THRIFT-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929633#action_12929633 ] David Reiss commented on THRIFT-970: That's my preference, but Bryan is a better judge

[jira] Commented: (THRIFT-970) Under heavy load, THttpClient may fail with "too many open files"

[ https://issues.apache.org/jira/browse/THRIFT-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929248#action_12929248 ] David Reiss commented on THRIFT-970: I just noticed the change to ivy.xml. Does this m

[jira] Commented: (THRIFT-916) gcc warnings in c++ header files

[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928526#action_12928526 ] David Reiss commented on THRIFT-916: Commenting out the name is illegal in C, so I've g

[jira] Commented: (THRIFT-916) gcc warnings in c++ header files

[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928407#action_12928407 ] David Reiss commented on THRIFT-916: I think the proper way to handle those in C++ is t

[jira] Commented: (THRIFT-953) make check fails in TransportTest.cpp

[ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927769#action_12927769 ] David Reiss commented on THRIFT-953: Sounds good to me. I'd also be fine with just usi

[jira] Resolved: (THRIFT-927) Add option to modify the PHP include path

[ https://issues.apache.org/jira/browse/THRIFT-927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Reiss resolved THRIFT-927. Resolution: Fixed Fix Version/s: 0.6 Assignee: David Reiss > Add option to modify t

[jira] Resolved: (THRIFT-929) Improvements to the C++ test suite

[ https://issues.apache.org/jira/browse/THRIFT-929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Reiss resolved THRIFT-929. Resolution: Fixed Fix Version/s: 0.6 Assignee: David Reiss > Improvements to the C+

[jira] Resolved: (THRIFT-925) Provide name<->value map for enums in C++

[ https://issues.apache.org/jira/browse/THRIFT-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Reiss resolved THRIFT-925. Resolution: Fixed Fix Version/s: 0.6 Assignee: David Reiss > Provide name<->value m

[jira] Resolved: (THRIFT-922) Templatized [de]serialization code for C++

[ https://issues.apache.org/jira/browse/THRIFT-922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Reiss resolved THRIFT-922. Resolution: Fixed Fix Version/s: 0.6 Assignee: David Reiss > Templatized [de]serial

[jira] Resolved: (THRIFT-926) Miscellaneous C++ improvements

[ https://issues.apache.org/jira/browse/THRIFT-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Reiss resolved THRIFT-926. Resolution: Fixed Fix Version/s: 0.6 Assignee: David Reiss > Miscellaneous C++ impr

[jira] Resolved: (THRIFT-928) Make more statistics available in C++ servers

[ https://issues.apache.org/jira/browse/THRIFT-928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Reiss resolved THRIFT-928. Resolution: Fixed Fix Version/s: 0.6 Assignee: David Reiss > Make more statistics a

[jira] Resolved: (THRIFT-924) Fix generated php structure constants

[ https://issues.apache.org/jira/browse/THRIFT-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Reiss resolved THRIFT-924. Resolution: Fixed Fix Version/s: 0.6 Assignee: David Reiss > Fix generated php stru

[jira] Resolved: (THRIFT-923) Event-driven client and server support for C++

[ https://issues.apache.org/jira/browse/THRIFT-923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Reiss resolved THRIFT-923. Resolution: Fixed Fix Version/s: 0.6 Assignee: David Reiss > Event-driven client an

[jira] Commented: (THRIFT-615) TThreadPoolServer doesn't call task_done after pulling tasks from it's clients queue

[ https://issues.apache.org/jira/browse/THRIFT-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927698#action_12927698 ] David Reiss commented on THRIFT-615: No. "except:" is really bad. It should be "excep

[jira] Commented: (THRIFT-978) better error message when pkg-config is missing

[ https://issues.apache.org/jira/browse/THRIFT-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927564#action_12927564 ] David Reiss commented on THRIFT-978: I don't think this is the right change. This prob