Bad data can cause TProtocolUtil.skip to take a lot of CPU in a do-nothing loop
---
Key: THRIFT-1175
URL: https://issues.apache.org/jira/browse/THRIFT-1175
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Donham reopened THRIFT-1047:
-
I did a micro benchmark showing that this change is < 0.5% slower. You could
argue that this is a w
[
https://issues.apache.org/jira/browse/THRIFT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988258#action_12988258
]
Jake Donham commented on THRIFT-1047:
-
Do you have benchmarking code around this you c
[
https://issues.apache.org/jira/browse/THRIFT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Donham closed THRIFT-1047.
---
Resolution: Not A Problem
OK, I did not know about Thrift.type_checking, thanks.
Honestly this seem
[
https://issues.apache.org/jira/browse/THRIFT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987383#action_12987383
]
Jake Donham commented on THRIFT-1047:
-
There is no checking higher up in the call chai
rb_thrift_memory_buffer_write treats arg as string without check, segfaults if
you pass non-string
--
Key: THRIFT-1047
URL: https://issues.apache.org/jira/browse/THRIF