[jira] [Resolved] (THRIFT-3620) Cleanup and consolidate Thrift* jenkins jobs.

2017-08-30 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois resolved THRIFT-3620. - Resolution: Fixed Others have moved jobs completely to Travis/AppVeyor, obsoleting this task. >

[jira] [Commented] (THRIFT-3620) Cleanup and consolidate Thrift* jenkins jobs.

2017-08-30 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148426#comment-16148426 ] John Sirois commented on THRIFT-3620: - [~jking3] if what you say is true I agree. I'l

[jira] [Commented] (THRIFT-3752) nil collections are serialized as empty collections

2017-02-21 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877173#comment-15877173 ] John Sirois commented on THRIFT-3752: - [~jking], I don't think so. The compiler still

[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI

2017-01-14 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822950#comment-15822950 ] John Sirois commented on THRIFT-4029: - This really is the behavior you want - mutable

[jira] [Commented] (THRIFT-3752) nil collections are serialized as empty collections

2016-03-27 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213669#comment-15213669 ] John Sirois commented on THRIFT-3752: - Actually [~jensg] - I can't make sense of the

[jira] [Commented] (THRIFT-3752) nil collections are serialized as empty collections

2016-03-27 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213646#comment-15213646 ] John Sirois commented on THRIFT-3752: - Noting the not-quite-yet-minted docs are here:

[jira] [Commented] (THRIFT-3752) nil collections are serialized as empty collections

2016-03-23 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209376#comment-15209376 ] John Sirois commented on THRIFT-3752: - OK - great. Thanks [~jensg]. After hitting t

[jira] [Comment Edited] (THRIFT-3752) nil collections are serialized as empty collections

2016-03-23 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208762#comment-15208762 ] John Sirois edited comment on THRIFT-3752 at 3/23/16 4:55 PM: -

[jira] [Commented] (THRIFT-3752) nil collections are serialized as empty collections

2016-03-23 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208762#comment-15208762 ] John Sirois commented on THRIFT-3752: - Hrm, so this may not be a thrift compiler bug

[jira] [Commented] (THRIFT-3700) Go Map has wrong default value when optional

2016-03-23 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208543#comment-15208543 ] John Sirois commented on THRIFT-3700: - [~connorgorman] - I filed THRIFT-3752 today wh

[jira] [Assigned] (THRIFT-3752) nil collections are serialized as empty collections

2016-03-23 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois reassigned THRIFT-3752: --- Assignee: John Sirois > nil collections are serialized as empty collections > --

[jira] [Created] (THRIFT-3752) nil collections are serialized as empty collections

2016-03-23 Thread John Sirois (JIRA)
John Sirois created THRIFT-3752: --- Summary: nil collections are serialized as empty collections Key: THRIFT-3752 URL: https://issues.apache.org/jira/browse/THRIFT-3752 Project: Thrift Issue Type

[jira] [Closed] (THRIFT-3622) Fix deprecated uses of std::auto_ptr

2016-02-16 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois closed THRIFT-3622. --- Resolution: Later > Fix deprecated uses of std::auto_ptr > > >

[jira] [Reopened] (THRIFT-3622) Fix deprecated uses of std::auto_ptr

2016-02-16 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois reopened THRIFT-3622: - Assignee: (was: John Sirois) > Fix deprecated uses of std::auto_ptr > -

[jira] [Closed] (THRIFT-3622) Fix deprecated uses of std::auto_ptr

2016-02-16 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois closed THRIFT-3622. --- Resolution: Later I'm going to close this issue for later until I understand the c/c++ build better

[jira] [Updated] (THRIFT-3623) Fix Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports

2016-02-14 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois updated THRIFT-3623: Fix Version/s: 0.9.4 > Fix Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports > --

[jira] [Resolved] (THRIFT-3623) Fix Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports

2016-02-14 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois resolved THRIFT-3623. - Resolution: Fixed > Fix Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports > ---

[jira] [Commented] (THRIFT-3609) Remove or replace TestPortFixture.h

2016-02-14 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146588#comment-15146588 ] John Sirois commented on THRIFT-3609: - Removal: https://github.com/apache/thrift/pull

[jira] [Commented] (THRIFT-3622) Fix deprecated uses of std::auto_ptr

2016-02-13 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146218#comment-15146218 ] John Sirois commented on THRIFT-3622: - CI went green here: https://builds.apache.org/

[jira] [Assigned] (THRIFT-3622) Fix deprecated uses of std::auto_ptr

2016-02-13 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois reassigned THRIFT-3622: --- Assignee: John Sirois > Fix deprecated uses of std::auto_ptr > -

[jira] [Commented] (THRIFT-3623) Fix Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports

2016-02-13 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146172#comment-15146172 ] John Sirois commented on THRIFT-3623: - CI went green here: https://builds.apache.org/

[jira] [Created] (THRIFT-3628) Fix lib/cpp/test/TServerIntegrationTest.cpp to use ephemeral ports

2016-02-13 Thread John Sirois (JIRA)
John Sirois created THRIFT-3628: --- Summary: Fix lib/cpp/test/TServerIntegrationTest.cpp to use ephemeral ports Key: THRIFT-3628 URL: https://issues.apache.org/jira/browse/THRIFT-3628 Project: Thrift

[jira] [Commented] (THRIFT-3625) Kill unused #include "TestPortFixture.h" in lib/cpp/test/TServerTransportTest.cpp.

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145828#comment-15145828 ] John Sirois commented on THRIFT-3625: - Now green @ https://builds.apache.org/job/Thri

[jira] [Commented] (THRIFT-3626) Fix lib/cpp/test/TSocketInterruptTest.cpp to use ephemeral ports.

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145825#comment-15145825 ] John Sirois commented on THRIFT-3626: - Now green @ https://builds.apache.org/job/Thri

[jira] [Commented] (THRIFT-3623) Fix Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145811#comment-15145811 ] John Sirois commented on THRIFT-3623: - Build went green @ https://builds.apache.org/j

[jira] [Comment Edited] (THRIFT-3620) Cleanup and consolidate Thrift* jenkins jobs.

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145795#comment-15145795 ] John Sirois edited comment on THRIFT-3620 at 2/13/16 4:41 AM: -

[jira] [Commented] (THRIFT-3620) Cleanup and consolidate Thrift* jenkins jobs.

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145795#comment-15145795 ] John Sirois commented on THRIFT-3620: - I'm agree 100% on the ability for any contribu

[jira] [Commented] (THRIFT-3626) Fix lib/cpp/test/TSocketInterruptTest.cpp to use ephemeral ports.

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145781#comment-15145781 ] John Sirois commented on THRIFT-3626: - https://github.com/apache/thrift/pull/857 > F

[jira] [Created] (THRIFT-3626) Fix lib/cpp/test/TSocketInterruptTest.cpp to use ephemeral ports.

2016-02-12 Thread John Sirois (JIRA)
John Sirois created THRIFT-3626: --- Summary: Fix lib/cpp/test/TSocketInterruptTest.cpp to use ephemeral ports. Key: THRIFT-3626 URL: https://issues.apache.org/jira/browse/THRIFT-3626 Project: Thrift

[jira] [Commented] (THRIFT-3625) Kill unused #include "TestPortFixture.h" in lib/cpp/test/TServerTransportTest.cpp.

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145667#comment-15145667 ] John Sirois commented on THRIFT-3625: - https://github.com/apache/thrift/pull/856 > K

[jira] [Created] (THRIFT-3625) Kill unused #include "TestPortFixture.h" in lib/cpp/test/TServerTransportTest.cpp.

2016-02-12 Thread John Sirois (JIRA)
John Sirois created THRIFT-3625: --- Summary: Kill unused #include "TestPortFixture.h" in lib/cpp/test/TServerTransportTest.cpp. Key: THRIFT-3625 URL: https://issues.apache.org/jira/browse/THRIFT-3625 Proj

[jira] [Commented] (THRIFT-3624) Fix lib/cpp/test/TServerSocketTest.cpp to use ephemeral ports

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145645#comment-15145645 ] John Sirois commented on THRIFT-3624: - https://github.com/apache/thrift/pull/855 > F

[jira] [Updated] (THRIFT-3621) Fix lib/cpp/test/SecurityTest.cpp to use ephemeral ports

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois updated THRIFT-3621: Description: As part of work on THRIFT-3609, eliminate use of TestPortFixture.h from SecurityTest.

[jira] [Created] (THRIFT-3624) Fix lib/cpp/test/TServerSocketTest.cpp to use ephemeral ports

2016-02-12 Thread John Sirois (JIRA)
John Sirois created THRIFT-3624: --- Summary: Fix lib/cpp/test/TServerSocketTest.cpp to use ephemeral ports Key: THRIFT-3624 URL: https://issues.apache.org/jira/browse/THRIFT-3624 Project: Thrift

[jira] [Commented] (THRIFT-3623) Fix Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145634#comment-15145634 ] John Sirois commented on THRIFT-3623: - https://github.com/apache/thrift/pull/854 > F

[jira] [Created] (THRIFT-3623) Fix Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports

2016-02-12 Thread John Sirois (JIRA)
John Sirois created THRIFT-3623: --- Summary: Fix Fix cpp/lib/test/TSSLSocketInterruptTest.cpp to use ephemeral ports Key: THRIFT-3623 URL: https://issues.apache.org/jira/browse/THRIFT-3623 Project: Thrift

[jira] [Created] (THRIFT-3622) Fix deprecated uses of std::auto_ptr

2016-02-12 Thread John Sirois (JIRA)
John Sirois created THRIFT-3622: --- Summary: Fix deprecated uses of std::auto_ptr Key: THRIFT-3622 URL: https://issues.apache.org/jira/browse/THRIFT-3622 Project: Thrift Issue Type: Task

[jira] [Commented] (THRIFT-3621) Fix lib/cpp/test/SecurityTest.cpp to use ephemeral ports

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145529#comment-15145529 ] John Sirois commented on THRIFT-3621: - https://github.com/apache/thrift/pull/853 > F

[jira] [Created] (THRIFT-3621) Fix lib/cpp/test/SecurityTest.cpp to use ephemeral ports

2016-02-12 Thread John Sirois (JIRA)
John Sirois created THRIFT-3621: --- Summary: Fix lib/cpp/test/SecurityTest.cpp to use ephemeral ports Key: THRIFT-3621 URL: https://issues.apache.org/jira/browse/THRIFT-3621 Project: Thrift Issue

[jira] [Commented] (THRIFT-3620) Cleanup and consolidate Thrift* jenkins jobs.

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145263#comment-15145263 ] John Sirois commented on THRIFT-3620: - Ok - it would be nice to have a single job and

[jira] [Assigned] (THRIFT-3620) Cleanup and consolidate Thrift* jenkins jobs.

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois reassigned THRIFT-3620: --- Assignee: John Sirois > Cleanup and consolidate Thrift* jenkins jobs. >

[jira] [Commented] (THRIFT-3620) Cleanup and consolidate Thrift* jenkins jobs.

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145116#comment-15145116 ] John Sirois commented on THRIFT-3620: - [~jfarrell], [~jensg], [~roger.meier] and [~ns

[jira] [Created] (THRIFT-3620) Cleanup and consolidate Thrift* jenkins jobs.

2016-02-12 Thread John Sirois (JIRA)
John Sirois created THRIFT-3620: --- Summary: Cleanup and consolidate Thrift* jenkins jobs. Key: THRIFT-3620 URL: https://issues.apache.org/jira/browse/THRIFT-3620 Project: Thrift Issue Type: Task

[jira] [Commented] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145025#comment-15145025 ] John Sirois commented on THRIFT-3112: - The PROPOSAL thread has had 1 positive respons

[jira] [Commented] (THRIFT-3608) lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144951#comment-15144951 ] John Sirois commented on THRIFT-3608: - Thank you! Thrift-precommit should hopefully b

[jira] [Commented] (THRIFT-3616) lib/py/test/test_sslsocket.py is flaky

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144950#comment-15144950 ] John Sirois commented on THRIFT-3616: - Thanks [~nsuke]! > lib/py/test/test_sslsocket

[jira] [Commented] (THRIFT-3616) lib/py/test/test_sslsocket.py is flaky

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144928#comment-15144928 ] John Sirois commented on THRIFT-3616: - Ah yes, I misread 8 and 9 here: https://thrif

[jira] [Commented] (THRIFT-3608) lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144733#comment-15144733 ] John Sirois commented on THRIFT-3608: - I'm not sure I follow the don't wait part. I

[jira] [Commented] (THRIFT-3616) lib/py/test/test_sslsocket.py is flaky

2016-02-12 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144683#comment-15144683 ] John Sirois commented on THRIFT-3616: - https://github.com/apache/thrift/pull/850 > l

[jira] [Comment Edited] (THRIFT-3616) lib/py/test/test_sslsocket.py is flaky

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143542#comment-15143542 ] John Sirois edited comment on THRIFT-3616 at 2/11/16 9:34 PM: -

[jira] [Commented] (THRIFT-3616) lib/py/test/test_sslsocket.py is flaky

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143542#comment-15143542 ] John Sirois commented on THRIFT-3616: - OK - I have a delay-free way to fix this that

[jira] [Updated] (THRIFT-3609) Remove or replace TestPortFixture.h

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois updated THRIFT-3609: Description: Today 6 cpp lib tests use [TestPortFixture.h|https://github.com/apache/thrift/blob/1f6

[jira] [Commented] (THRIFT-3616) lib/py/test/test_sslsocket.py is flaky

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143466#comment-15143466 ] John Sirois commented on THRIFT-3616: - /cc [~nsuke] - I'm going to work this presentl

[jira] [Commented] (THRIFT-3616) lib/py/test/test_sslsocket.py is flaky

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143462#comment-15143462 ] John Sirois commented on THRIFT-3616: - Seen multiple times over the course of working

[jira] [Commented] (THRIFT-3608) lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143459#comment-15143459 ] John Sirois commented on THRIFT-3608: - I filed this for the flaky python issue: THRIF

[jira] [Created] (THRIFT-3616) lib/py/test/test_sslsocket.py is flaky

2016-02-11 Thread John Sirois (JIRA)
John Sirois created THRIFT-3616: --- Summary: lib/py/test/test_sslsocket.py is flaky Key: THRIFT-3616 URL: https://issues.apache.org/jira/browse/THRIFT-3616 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-3362) make check fails for C++ at the SecurityTest

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143434#comment-15143434 ] John Sirois commented on THRIFT-3362: - Yeah - realized that late, but I spent 2 days

[jira] [Commented] (THRIFT-3608) lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143424#comment-15143424 ] John Sirois commented on THRIFT-3608: - [~jensg] - If you can confirm this fixes the i

[jira] [Commented] (THRIFT-3608) lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143423#comment-15143423 ] John Sirois commented on THRIFT-3608: - Passing now though failing at another ~commmon

[jira] [Resolved] (THRIFT-3362) make check fails for C++ at the SecurityTest

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois resolved THRIFT-3362. - Resolution: Duplicate Resolving as duplicate of THRIFT-3608 which has a fix spinning through CI h

[jira] [Commented] (THRIFT-3362) make check fails for C++ at the SecurityTest

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143375#comment-15143375 ] John Sirois commented on THRIFT-3362: - Noting that I figured this out over in THRIFT-

[jira] [Commented] (THRIFT-3608) lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143369#comment-15143369 ] John Sirois commented on THRIFT-3608: - Thanks [~jensg] - I'll comment over there and

[jira] [Issue Comment Deleted] (THRIFT-3608) lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois updated THRIFT-3608: Comment: was deleted (was: https://github.com/apache/thrift/pull/841) > lib/cpp/test/SecurityTest

[jira] [Commented] (THRIFT-3608) lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143290#comment-15143290 ] John Sirois commented on THRIFT-3608: - For posterity - this trick helped seal the dia

[jira] [Commented] (THRIFT-3608) lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

2016-02-11 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143283#comment-15143283 ] John Sirois commented on THRIFT-3608: - Real fix is here: https://github.com/apache/th

[jira] [Commented] (THRIFT-3608) lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

2016-02-10 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141258#comment-15141258 ] John Sirois commented on THRIFT-3608: - https://github.com/apache/thrift/pull/841 > l

[jira] [Created] (THRIFT-3609) Remove or replace TestPortFixture.h

2016-02-10 Thread John Sirois (JIRA)
John Sirois created THRIFT-3609: --- Summary: Remove or replace TestPortFixture.h Key: THRIFT-3609 URL: https://issues.apache.org/jira/browse/THRIFT-3609 Project: Thrift Issue Type: Improvement

[jira] [Comment Edited] (THRIFT-3608) lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

2016-02-10 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141086#comment-15141086 ] John Sirois edited comment on THRIFT-3608 at 2/10/16 4:55 PM: -

[jira] [Commented] (THRIFT-3608) lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

2016-02-10 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141086#comment-15141086 ] John Sirois commented on THRIFT-3608: - Since there is no assert message printed out i

[jira] [Created] (THRIFT-3608) lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

2016-02-10 Thread John Sirois (JIRA)
John Sirois created THRIFT-3608: --- Summary: lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build. Key: THRIFT-3608 URL: https://issues.apache.org/jira/browse/THRIFT-3608 Project: Thrift

[jira] [Commented] (THRIFT-3606) TSaslClientTransport props typed too strongly

2016-02-10 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140935#comment-15140935 ] John Sirois commented on THRIFT-3606: - [~nattobean], this sounds totally reasonable t

[jira] [Updated] (THRIFT-2157) generated code would cause ClassCastException

2016-02-08 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois updated THRIFT-2157: Component/s: Java - Library > generated code would cause ClassCastException > -

[jira] [Updated] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface

2016-02-08 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois updated THRIFT-3112: Component/s: Java - Library > [Java] AsyncMethodCallback should be typed in generated AsyncIface >

[jira] [Updated] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface

2016-02-08 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois updated THRIFT-3112: Labels: (was: easyfix) > [Java] AsyncMethodCallback should be typed in generated AsyncIface > ---

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

2016-02-08 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137652#comment-15137652 ] John Sirois commented on THRIFT-2157: - Turns out THRIFT-3112 does not reveal similar

[jira] [Commented] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface

2016-02-08 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137591#comment-15137591 ] John Sirois commented on THRIFT-3112: - Straw-man RB that implements the proposal: ht

[jira] [Commented] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface

2016-02-08 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137540#comment-15137540 ] John Sirois commented on THRIFT-3112: - Proposal thread here: http://markmail.org/mess

[jira] [Commented] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface

2016-02-08 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137318#comment-15137318 ] John Sirois commented on THRIFT-3112: - The fundamental problem here is that the async

[jira] [Assigned] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface

2016-02-05 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois reassigned THRIFT-3112: --- Assignee: John Sirois (was: Roger Meier) > [Java] AsyncMethodCallback should be typed in ge

[jira] [Commented] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface

2016-02-05 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134786#comment-15134786 ] John Sirois commented on THRIFT-3112: - I spoke with Roger offline and there are no ob

[jira] [Comment Edited] (THRIFT-3583) Add support for generating immutable java stubs for structs and unions

2016-02-04 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132978#comment-15132978 ] John Sirois edited comment on THRIFT-3583 at 2/4/16 8:41 PM: -

[jira] [Commented] (THRIFT-3583) Add support for generating immutable java stubs for structs and unions

2016-02-04 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132978#comment-15132978 ] John Sirois commented on THRIFT-3583: - Adding another blocker related to THRIFT-2157

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

2016-02-04 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132976#comment-15132976 ] John Sirois commented on THRIFT-2157: - Linking this to THRIFT-3112 which preliminary

[jira] [Comment Edited] (THRIFT-2157) generated code would cause ClassCastException

2016-02-04 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132966#comment-15132966 ] John Sirois edited comment on THRIFT-2157 at 2/4/16 8:32 PM: -

[jira] [Reopened] (THRIFT-2157) generated code would cause ClassCastException

2016-02-04 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois reopened THRIFT-2157: - Assignee: John Sirois (was: Marc Breslow) Re-opening since the ClassCastException is still not

[jira] [Commented] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface

2016-02-04 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132962#comment-15132962 ] John Sirois commented on THRIFT-3112: - [~roger.meier] I have begun to dig into the {{

[jira] [Assigned] (THRIFT-3583) Add support for generating immutable java stubs for structs and unions

2016-02-04 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Sirois reassigned THRIFT-3583: --- Assignee: John Sirois > Add support for generating immutable java stubs for structs and unio

[jira] [Comment Edited] (THRIFT-3597) `make check` hangs in go tests

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131518#comment-15131518 ] John Sirois edited comment on THRIFT-3597 at 2/4/16 1:31 AM: -

[jira] [Commented] (THRIFT-3597) `make check` hangs in go tests

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131518#comment-15131518 ] John Sirois commented on THRIFT-3597: - [~nsuke] - I think this is the real fix for yo

[jira] [Commented] (THRIFT-3597) `make check` hangs in go tests

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131433#comment-15131433 ] John Sirois commented on THRIFT-3597: - [~dimi...@gmail.com], if you have a chance to

[jira] [Commented] (THRIFT-3597) `make check` hangs in go tests

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131432#comment-15131432 ] John Sirois commented on THRIFT-3597: - https://github.com/apache/thrift/pull/833 > `

[jira] [Commented] (THRIFT-3583) Add support for generating immutable java stubs for structs and unions

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131417#comment-15131417 ] John Sirois commented on THRIFT-3583: - [~jfarrell] any hints on how I self-assign thi

[jira] [Commented] (THRIFT-3583) Add support for generating immutable java stubs for structs and unions

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131416#comment-15131416 ] John Sirois commented on THRIFT-3583: - THRIFT-3597 doesn't really block, but hit this

[jira] [Commented] (THRIFT-3597) `make check` hangs in go tests

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131412#comment-15131412 ] John Sirois commented on THRIFT-3597: - I can't find how to self-assign but I have a p

[jira] [Created] (THRIFT-3597) `make check` hangs in go tests

2016-02-03 Thread John Sirois (JIRA)
John Sirois created THRIFT-3597: --- Summary: `make check` hangs in go tests Key: THRIFT-3597 URL: https://issues.apache.org/jira/browse/THRIFT-3597 Project: Thrift Issue Type: Bug Compo

[jira] [Commented] (THRIFT-3583) Add support for generating immutable java stubs for structs and unions

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131143#comment-15131143 ] John Sirois commented on THRIFT-3583: - Adding THRIFT-2157 as a blocker even though it

[jira] [Commented] (THRIFT-3583) Add support for generating immutable java stubs for structs and unions

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131140#comment-15131140 ] John Sirois commented on THRIFT-3583: - Ran into this 1/2-way refactoring of TBase whe

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

2016-02-03 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131098#comment-15131098 ] John Sirois commented on THRIFT-2157: - [~jensg] or [~mbreslow] Is there more coming i

[jira] [Commented] (THRIFT-3583) Add support for generating immutable java stubs for structs and unions

2016-01-28 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121911#comment-15121911 ] John Sirois commented on THRIFT-3583: - Started a discussion here to vet the idea and

[jira] [Commented] (THRIFT-3583) Add support for generating immutable java stubs for structs and unions

2016-01-28 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121757#comment-15121757 ] John Sirois commented on THRIFT-3583: - Another class of complications comes from coll

  1   2   >