[jira] [Commented] (THRIFT-5230) Fix connection leak and CancelledKeyException when handling Epoll bug

2020-06-17 Thread Keith Turner (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138516#comment-17138516 ] Keith Turner commented on THRIFT-5230: -- [~jensg] I can look into it. > Fix connection l

[jira] [Created] (THRIFT-4847) CancelledKeyException causes TThreadedSelectorServer to fail.

2019-04-10 Thread Keith Turner (JIRA)
Keith Turner created THRIFT-4847: Summary: CancelledKeyException causes TThreadedSelectorServer to fail. Key: THRIFT-4847 URL: https://issues.apache.org/jira/browse/THRIFT-4847 Project: Thrift

[GitHub] thrift pull request #1186: THRIFT-1805 Provide option for handling RTEs

2017-02-13 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/thrift/pull/1186#discussion_r10097 --- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc --- @@ -5265,6 +5274,9 @@ THRIFT_REGISTER_GENERATOR( "android_legacy

[GitHub] thrift pull request #1186: THRIFT-1805 Provide option for handling RTEs

2017-02-13 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/thrift/pull/1186#discussion_r100875982 --- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc --- @@ -5265,6 +5274,9 @@ THRIFT_REGISTER_GENERATOR( "android_legacy

[GitHub] thrift pull request #1186: THRIFT-1805 Provide option for handling RTEs

2017-02-13 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/thrift/pull/1186#discussion_r100861533 --- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc --- @@ -5265,6 +5274,9 @@ THRIFT_REGISTER_GENERATOR( "android_legacy

[GitHub] thrift pull request #1186: THRIFT-1805 Provide option for handling RTEs

2017-02-10 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/thrift/pull/1186#discussion_r100562753 --- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc --- @@ -91,6 +92,8 @@ class t_java_generator : public t_oop_generator

[jira] [Created] (THRIFT-3478) Restore dropped method to THsHaServer.java

2015-12-08 Thread Keith Turner (JIRA)
Keith Turner created THRIFT-3478: Summary: Restore dropped method to THsHaServer.java Key: THRIFT-3478 URL: https://issues.apache.org/jira/browse/THRIFT-3478 Project: Thrift Issue Type: Bug

[GitHub] thrift pull request: THRIFT-3478 restore method to THsHaServer

2015-12-08 Thread keith-turner
GitHub user keith-turner opened a pull request: https://github.com/apache/thrift/pull/735 THRIFT-3478 restore method to THsHaServer You can merge this pull request into a Git repository by running: $ git pull https://github.com/keith-turner/thrift THRIFT-3478 Alternatively

Re: API Stability Guarantees?

2015-12-07 Thread Keith Turner
> I already saw a few instances where users assumed it is a bug fix release. >> We'd be better off choosing a more informative number like 0.10.0 next (or >> 1.0.0 of course). >> >> On Thu, Dec 3, 2015 at 12:05 AM Keith Turner <ke...@deenlo.com> wrote: >> >

Re: API Stability Guarantees?

2015-12-07 Thread Keith Turner
ances where users assumed it is a bug fix release. > We'd be better off choosing a more informative number like 0.10.0 next (or > 1.0.0 of course). > > On Thu, Dec 3, 2015 at 12:05 AM Keith Turner <ke...@deenlo.com> wrote: > > > On Tue, Dec 1, 2015 at 7:11 PM, Jens Geyer

Re: API Stability Guarantees?

2015-12-02 Thread Keith Turner
28bc757a1b64bac5f7faaL47 > process by means of the (relatively new) audit feature: > > >$ thrift --audit myapi-v2.thrift myapi-v1.thrift >[Thrift Audit Failure:myapi-v2.thrift] New Thrift File has missing > function bar > > > Have fun, > JensG > > &

API Stability Guarantees?

2015-12-01 Thread Keith Turner
In THRIFT-3202[1] a method was dropped (in a bug fix release.. IMHO that method should have been deprecated). Dropping that method prevents a seemless upgrade for Accumulo[2] . This problem made wonder if the Thrift project has any agreed upon API stability guarantees? [1] :

[jira] [Commented] (THRIFT-1805) Thrift should not swallow ALL exceptions

2015-12-01 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033849#comment-15033849 ] Keith Turner commented on THRIFT-1805: -- Just want to chime in and explain Accumulo's use case

[jira] [Updated] (THRIFT-1658) Java thrift server is not throwing TApplicationException

2012-07-26 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Turner updated THRIFT-1658: - Attachment: THRIFT-1658.txt I took at stab at fixing this, here is a patch. This is my first

[jira] [Commented] (THRIFT-1658) Java thrift server is not throwing TApplicationException

2012-07-26 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423342#comment-13423342 ] Keith Turner commented on THRIFT-1658: -- FYI I create the patch off of the 0.8.x

[jira] [Created] (THRIFT-1658) Java thrift server is not throwing TApplicationException

2012-07-25 Thread Keith Turner (JIRA)
Keith Turner created THRIFT-1658: Summary: Java thrift server is not throwing TApplicationException Key: THRIFT-1658 URL: https://issues.apache.org/jira/browse/THRIFT-1658 Project: Thrift