[GitHub] thrift issue #1363: THRIFT-4331 - C++: TSSLSocket fixes

2017-10-06 Thread MartinHaimberger
Github user MartinHaimberger commented on the issue: https://github.com/apache/thrift/pull/1363 rebased and indentations should be fixed ---

[GitHub] thrift pull request #1362: THRIFT-4331 - C++: TSSLSocket fixes on branch 0.1...

2017-09-18 Thread MartinHaimberger
Github user MartinHaimberger closed the pull request at: https://github.com/apache/thrift/pull/1362 ---

[GitHub] thrift pull request #1363: THRIFT-4331 - C++: TSSLSocket fixes

2017-09-17 Thread MartinHaimberger
Github user MartinHaimberger commented on a diff in the pull request: https://github.com/apache/thrift/pull/1363#discussion_r139311583 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp --- @@ -759,7 +775,9 @@ unsigned int TSSLSocket::waitForEvent(bool wantRead) { struct

[GitHub] thrift pull request #1363: THRIFT-4331 - C++: TSSLSocket fixes

2017-09-15 Thread MartinHaimberger
GitHub user MartinHaimberger opened a pull request: https://github.com/apache/thrift/pull/1363 THRIFT-4331 - C++: TSSLSocket fixes fixed issue with large messages, where waitForEvent was called mutliple times waiting for SSL_read() to get bytes and running in the retry

[GitHub] thrift pull request #1362: C++: TSSLSocket fixes

2017-09-15 Thread MartinHaimberger
GitHub user MartinHaimberger opened a pull request: https://github.com/apache/thrift/pull/1362 C++: TSSLSocket fixes fixed issue with large messages, where waitForEvent was called mutliple times waiting for SSL_read() to get bytes and running in the retry timeout

[GitHub] thrift pull request: C++ transport: implement interruptable TSSLSo...

2015-11-19 Thread MartinHaimberger
Github user MartinHaimberger commented on the pull request: https://github.com/apache/thrift/pull/690#issuecomment-158115251 @jeking3 tests and nonblocking accept connect and close are implemented now --- If your project is set up for it, you can reply to this email and have your

[GitHub] thrift pull request: C++ transport: implement interruptable TSSLSo...

2015-11-17 Thread MartinHaimberger
Github user MartinHaimberger commented on a diff in the pull request: https://github.com/apache/thrift/pull/690#discussion_r45071978 --- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp --- @@ -659,6 +659,10 @@ shared_ptr TServerSocket::createSocket(THRIFT_SOCKET clientSocket

[GitHub] thrift pull request: C++ transport: implement interruptable TSSLSo...

2015-11-17 Thread MartinHaimberger
Github user MartinHaimberger commented on the pull request: https://github.com/apache/thrift/pull/690#issuecomment-157402412 @jeking3 i will also implement the TSSLSocketInterruptTest --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] thrift pull request: C++ transport: implement interruptable TSSLSo...

2015-11-12 Thread MartinHaimberger
GitHub user MartinHaimberger opened a pull request: https://github.com/apache/thrift/pull/690 C++ transport: implement interruptable TSSLSocket - implement interruptable TSSLSocket using non-blocking sockets and non-blocking bios - introduce getter getInterruptSocket

[GitHub] thrift pull request: C++ transport: implement interruptable TSSLSo...

2015-11-12 Thread MartinHaimberger
Github user MartinHaimberger commented on the pull request: https://github.com/apache/thrift/pull/690#issuecomment-156150828 Build is failing because cabal could not be downloaded and installed /home/travis/build.sh: line 45: cabal: command not found