[jira] [Comment Edited] (THRIFT-2063) Go compiler cannot create code for maps with a map as key

2013-07-16 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710115#comment-13710115 ] Travis Cline edited comment on THRIFT-2063 at 7/16/13 7:22 PM:

[jira] [Commented] (THRIFT-2063) Go compiler cannot create code for maps with a map as key

2013-07-16 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710115#comment-13710115 ] Travis Cline commented on THRIFT-2063: -- In my opinion this should be accepted as a c

[jira] [Commented] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-06-29 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696235#comment-13696235 ] Travis Cline commented on THRIFT-1600: -- This can be considered closed by THRIFT-2012

[jira] [Commented] (THRIFT-2063) Go compiler cannot create code for maps with a map as key

2013-06-29 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696234#comment-13696234 ] Travis Cline commented on THRIFT-2063: -- This is a language constraint issue as the p

[jira] [Commented] (THRIFT-2012) Modernizing Go

2013-06-19 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688370#comment-13688370 ] Travis Cline commented on THRIFT-2012: -- Just to note (talked to jfarrell in irc abou

[jira] [Updated] (THRIFT-2012) Modernizing Go

2013-06-18 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-2012: - Attachment: 0001-THRIFT-2012-Modernize-Go-v5.patch This patch addresses a test failure and has h

[jira] [Updated] (THRIFT-2012) Modernizing Go

2013-06-17 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-2012: - Attachment: 0001-THRIFT-2012-Modernize-Go-v4.patch This patch includes the JSON fix patch from J

[jira] [Updated] (THRIFT-2012) Modernizing Go

2013-06-11 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-2012: - Attachment: 0001-THRIFT-2012-Modernize-Go-v3.patch Worked with Jens to identify a few issues, up

[jira] [Updated] (THRIFT-2012) Modernizing Go

2013-06-11 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-2012: - Attachment: 0001-THRIFT-2012-Modernize-Go-v2.patch I had missed ".git" in the go get url for git

[jira] [Commented] (THRIFT-2012) Modernizing Go

2013-06-09 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679221#comment-13679221 ] Travis Cline commented on THRIFT-2012: -- Jens, it was made against 0e07ec81620 but ap

[jira] [Commented] (THRIFT-2007) Go generator may produce invalid UTF-8

2013-06-09 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678984#comment-13678984 ] Travis Cline commented on THRIFT-2007: -- It's still produced, it's just the gofmt cle

[jira] [Comment Edited] (THRIFT-2008) Go comment missing linebreaks

2013-06-08 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678908#comment-13678908 ] Travis Cline edited comment on THRIFT-2008 at 6/9/13 2:56 AM: -

[jira] [Updated] (THRIFT-2012) Modernizing Go

2013-06-08 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-2012: - Attachment: 0001-THRIFT-2012-Modernize-Go.patch > Modernizing Go > --- > >

[jira] [Comment Edited] (THRIFT-2007) Go generator may produce invalid UTF-8

2013-06-08 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678918#comment-13678918 ] Travis Cline edited comment on THRIFT-2007 at 6/9/13 2:50 AM: -

[jira] [Commented] (THRIFT-2007) Go generator may produce invalid UTF-8

2013-06-08 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678918#comment-13678918 ] Travis Cline commented on THRIFT-2007: -- This appears to be a problem for most if not

[jira] [Commented] (THRIFT-2007) Go generator may produce invalid UTF-8

2013-06-08 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678916#comment-13678916 ] Travis Cline commented on THRIFT-2007: -- This is not window-specific.

[jira] [Commented] (THRIFT-2008) Go comment missing linebreaks

2013-06-08 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678908#comment-13678908 ] Travis Cline commented on THRIFT-2008: -- I have this in the updated patch on THRIFT-1

[jira] [Comment Edited] (THRIFT-2008) Go comment missing linebreaks

2013-06-08 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678908#comment-13678908 ] Travis Cline edited comment on THRIFT-2008 at 6/9/13 1:57 AM: -

[jira] [Updated] (THRIFT-1980) Modernize Go tooling, fix go client libary.

2013-06-08 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1980: - Attachment: 0001-THRIFT-1980-Go-Modernize-go-tooling.-Update-autoconf.patch I'm attaching an upd

[jira] [Closed] (THRIFT-1979) change t_generator::generate_docstring_comment to take an ostream

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline closed THRIFT-1979. Resolution: Fixed > change t_generator::generate_docstring_comment to take an ostream > --

[jira] [Commented] (THRIFT-1979) change t_generator::generate_docstring_comment to take an ostream

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667983#comment-13667983 ] Travis Cline commented on THRIFT-1979: -- The same goal can be accomplished just with

[jira] [Commented] (THRIFT-1980) Modernize Go tooling, fix go client libary.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667964#comment-13667964 ] Travis Cline commented on THRIFT-1980: -- If you're paying attention to Go in thrift y

[jira] [Updated] (THRIFT-1980) Modernize Go tooling, fix go client libary.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1980: - Description: This patch improves some of the Go tooling to get it inline with modern (post-1.0)

[jira] [Updated] (THRIFT-1980) Modernize Go tooling, fix go client libary.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1980: - Attachment: (was: 0001-THRIFT-1980-Go-Update-autoconf-for-modern-go-direct-.patch) > Mo

[jira] [Updated] (THRIFT-1980) Modernize Go tooling, fix go client libary.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1980: - Attachment: 0004-Fix-imports-add-package-prefixes-configurable-thrift.patch 0003-

[jira] [Updated] (THRIFT-1980) Modernize Go tooling, fix go client libary.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1980: - Description: This patch improves some of the Go tooling to get it inline with modern (post-1.0)

[jira] [Updated] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1600: - Attachment: (was: 0004-Fix-imports-add-package-prefixes-configurable-thrift.patch) > Th

[jira] [Updated] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1600: - Attachment: (was: 0003-Update-tutorial-code-for-go1.patch) > Thrift Go Compiler and Libr

[jira] [Updated] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1600: - Attachment: (was: 0002-Integrate-changes-from-github.com-pomack-thrift4go.patch) > Thri

[jira] [Commented] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667954#comment-13667954 ] Travis Cline commented on THRIFT-1600: -- I'm actually going to retract my patches pos

[jira] [Commented] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667936#comment-13667936 ] Travis Cline commented on THRIFT-1600: -- Laurent - yes, the go situation is a little

[jira] [Commented] (THRIFT-1347) Unify the exceptions returned in generated Go code

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667920#comment-13667920 ] Travis Cline commented on THRIFT-1347: -- This patch is outdated (os.Error doesn't exi

[jira] [Updated] (THRIFT-1980) Modernize Go tooling

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1980: - Attachment: (was: 0001-THRIFT-1980-Go-Update-autoconf-for-modern-go-direct-.patch) > Mo

[jira] [Updated] (THRIFT-1980) Modernize Go tooling

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1980: - Attachment: 0001-THRIFT-1980-Go-Update-autoconf-for-modern-go-direct-.patch > Modernize Go t

[jira] [Updated] (THRIFT-1980) Modernize Go tooling

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1980: - Description: This patch improves some of the Go tooling to get it inline with modern (post-1.0)

[jira] [Issue Comment Deleted] (THRIFT-1980) Modernize Go tooling

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1980: - Comment: was deleted (was: This patch simplifies (removes) the autoconf work and instead suggest

[jira] [Updated] (THRIFT-1980) Modernize Go tooling

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1980: - Component/s: Go - Compiler Priority: Major (was: Minor) Description

[jira] [Updated] (THRIFT-1980) Modernize Go tooling

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1980: - Attachment: 0001-THRIFT-1980-Go-Update-autoconf-for-modern-go-direct-.patch > Modernize Go t

[jira] [Updated] (THRIFT-1980) Modernize Go tooling

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1980: - Attachment: (was: 0001-Simply-autoconf-for-Go-Direct-users-to-use-go-get.patch) > Moder

[jira] [Commented] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667907#comment-13667907 ] Travis Cline commented on THRIFT-1600: -- Laurent, I uploaded new patch here that shou

[jira] [Updated] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1600: - Attachment: (was: 0003-Update-tutorial-code-for-go1.patch) > Thrift Go Compiler and Libr

[jira] [Updated] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1600: - Attachment: (was: 0004-Fix-imports-add-package-prefixes-configurable-thrift.patch) > Th

[jira] [Commented] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667892#comment-13667892 ] Travis Cline commented on THRIFT-1600: -- Laurent: Sorry, that patch was applied after

[jira] [Updated] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1600: - Attachment: (was: 0002-Integrate-changes-from-github.com-pomack-thrift4go.patch) > Thri

[jira] [Updated] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1600: - Attachment: 0004-Fix-imports-add-package-prefixes-configurable-thrift.patch 0003-

[jira] [Created] (THRIFT-1980) Encourage use of go get for Go client library.

2013-05-27 Thread Travis Cline (JIRA)
Travis Cline created THRIFT-1980: Summary: Encourage use of go get for Go client library. Key: THRIFT-1980 URL: https://issues.apache.org/jira/browse/THRIFT-1980 Project: Thrift Issue Type: I

[jira] [Updated] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1600: - Attachment: 0002-Integrate-changes-from-github.com-pomack-thrift4go.patch 0003-Up

[jira] [Comment Edited] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667698#comment-13667698 ] Travis Cline edited comment on THRIFT-1600 at 5/27/13 11:23 AM: ---

[jira] [Updated] (THRIFT-1980) Encourage use of go get for Go client library.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1980: - Attachment: 0001-Simply-autoconf-for-Go-Direct-users-to-use-go-get.patch This patch simplifies (

[jira] [Comment Edited] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667698#comment-13667698 ] Travis Cline edited comment on THRIFT-1600 at 5/27/13 11:22 AM: ---

[jira] [Updated] (THRIFT-1600) Thrift Go Compiler and Library out of date with Go 1 Release.

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1600: - Attachment: 0004-Fix-imports-add-package-prefixes-configurable-thrift.patch This patch fixes gen

[jira] [Updated] (THRIFT-1979) change t_generator::generate_docstring_comment to take an ostream

2013-05-27 Thread Travis Cline (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Cline updated THRIFT-1979: - Attachment: 1979.patch > change t_generator::generate_docstring_comment to take an ostream >

[jira] [Created] (THRIFT-1979) change t_generator::generate_docstring_comment to take an ostream

2013-05-27 Thread Travis Cline (JIRA)
Travis Cline created THRIFT-1979: Summary: change t_generator::generate_docstring_comment to take an ostream Key: THRIFT-1979 URL: https://issues.apache.org/jira/browse/THRIFT-1979 Project: Thrift