[jira] [Commented] (THRIFT-4688) Add thrift 0.12.0 to npmjs and/or add committers to apache org account

2019-02-12 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765952#comment-16765952 ] Wade Simmons commented on THRIFT-4688: -- [~jking3] I have added you as a mainta

[jira] [Closed] (THRIFT-3494) Node.js cannot handle ArrayBuffer

2015-12-17 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons closed THRIFT-3494. Resolution: Invalid Actually, it looks like this fix is improper and there is some other issue

[jira] [Updated] (THRIFT-3494) Node.js cannot handle ArrayBuffer

2015-12-17 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-3494: - Summary: Node.js cannot handle ArrayBuffer (was: Node.js should use Buffer.isBuffer) > Node

[jira] [Updated] (THRIFT-3494) Node.js should use Buffer.isBuffer

2015-12-17 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-3494: - Description: Newer versions of Node.js (such as 4.2.x) use multiple implementations for Buffer

[jira] [Created] (THRIFT-3494) Node.js should use Buffer.isBuffer

2015-12-17 Thread Wade Simmons (JIRA)
Wade Simmons created THRIFT-3494: Summary: Node.js should use Buffer.isBuffer Key: THRIFT-3494 URL: https://issues.apache.org/jira/browse/THRIFT-3494 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-2622) Expecting > 4 bytes, found only 2

2014-07-15 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063157#comment-14063157 ] Wade Simmons commented on THRIFT-2622: -- I'm pretty sure you are running

[jira] [Created] (THRIFT-2595) Node.js: Fix global leaks and copy-paste errors

2014-07-01 Thread Wade Simmons (JIRA)
Wade Simmons created THRIFT-2595: Summary: Node.js: Fix global leaks and copy-paste errors Key: THRIFT-2595 URL: https://issues.apache.org/jira/browse/THRIFT-2595 Project: Thrift Issue Type

[jira] [Updated] (THRIFT-2595) Node.js: Fix global leaks and copy-paste errors

2014-07-01 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-2595: - Attachment: 0001-fix-global-leaks-and-copy-paste-errors.patch > Node.js: Fix global leaks

[jira] [Commented] (THRIFT-1754) RangeError in buffer handling

2014-06-30 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047883#comment-14047883 ] Wade Simmons commented on THRIFT-1754: -- This may be fixed with THRIFT-2591, w

[jira] [Updated] (THRIFT-2591) TFramedTransport does not handle payloads split across packets correctly

2014-06-27 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-2591: - Attachment: 0001-fix-TFramedTransport-residual-continuation.patch Re-upload patch, old one had

[jira] [Updated] (THRIFT-2591) TFramedTransport does not handle payloads split across packets correctly

2014-06-27 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-2591: - Attachment: (was: 0001-fix-TFramedTransport-residual-continuation.patch) > TFramedTransp

[jira] [Commented] (THRIFT-2194) Node: Not actually prepending residual data in TFramedTransport.receiver

2014-06-27 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046394#comment-14046394 ] Wade Simmons commented on THRIFT-2194: -- This fix was accidentally reverte

[jira] [Updated] (THRIFT-2591) TFramedTransport does not handle payloads split across packets correctly

2014-06-27 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-2591: - Attachment: 0001-fix-TFramedTransport-residual-continuation.patch Patch to fix TFramedTransport

[jira] [Created] (THRIFT-2591) TFramedTransport does not handle payloads split across packets correctly

2014-06-27 Thread Wade Simmons (JIRA)
Wade Simmons created THRIFT-2591: Summary: TFramedTransport does not handle payloads split across packets correctly Key: THRIFT-2591 URL: https://issues.apache.org/jira/browse/THRIFT-2591 Project

[jira] [Commented] (THRIFT-1351) Compiler does not care about binary strings

2013-08-21 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746889#comment-13746889 ] Wade Simmons commented on THRIFT-1351: -- looks good t

[jira] [Commented] (THRIFT-1351) Compiler does not care about binary strings

2013-08-21 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746828#comment-13746828 ] Wade Simmons commented on THRIFT-1351: -- [~jensg] Yes, feel free to fix it u

[jira] [Commented] (THRIFT-1351) Compiler does not care about binary strings

2013-08-21 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746800#comment-13746800 ] Wade Simmons commented on THRIFT-1351: -- [~jensg] It wouldn't hurt, but th

[jira] [Updated] (THRIFT-1351) Compiler does not care about binary strings

2013-08-20 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-1351: - Attachment: 0001-read-binary-strings-with-readBinary.patch This really needs to be merged in to

[jira] [Commented] (THRIFT-1637) NPM registry does not include version 0.8

2013-06-19 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688398#comment-13688398 ] Wade Simmons commented on THRIFT-1637: -- Done: {code} $ npm owner add jfar

[jira] [Commented] (THRIFT-1637) NPM registry does not include version 0.8

2013-06-19 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688239#comment-13688239 ] Wade Simmons commented on THRIFT-1637: -- You can also create an account using

[jira] [Comment Edited] (THRIFT-1637) NPM registry does not include version 0.8

2013-06-19 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688144#comment-13688144 ] Wade Simmons edited comment on THRIFT-1637 at 6/19/13 5:0

[jira] [Commented] (THRIFT-1637) NPM registry does not include version 0.8

2013-06-19 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688144#comment-13688144 ] Wade Simmons commented on THRIFT-1637: -- I can transfer ownership of the &qu

[jira] [Commented] (THRIFT-1353) Switch to performance branch, get rid of BinaryParser

2013-06-18 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687357#comment-13687357 ] Wade Simmons commented on THRIFT-1353: -- Just want to make a clarification

[jira] [Resolved] (THRIFT-1637) NPM registry does not include version 0.8

2013-06-18 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons resolved THRIFT-1637. -- Resolution: Fixed Sorry for the delay in this. I have published 0.8.0 and 0.9.0 to npm

[jira] [Assigned] (THRIFT-1637) NPM registry does not include version 0.8

2013-06-18 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons reassigned THRIFT-1637: Assignee: Wade Simmons > NPM registry does not include version

[jira] [Commented] (THRIFT-1647) NodeJS FramedTransport does not work beyond the hello-world example

2012-08-01 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426982#comment-13426982 ] Wade Simmons commented on THRIFT-1647: -- Dan Cromer: Can you post an example se

[jira] [Commented] (THRIFT-1353) Switch to performance branch, get rid of BinaryParser

2012-05-14 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274738#comment-13274738 ] Wade Simmons commented on THRIFT-1353: -- Henrique Mendonca: Thanks for pus

[jira] [Issue Comment Edited] (THRIFT-1497) i64 type not supported in JavaScript. Low-order bits lost.

2012-01-20 Thread Wade Simmons (Issue Comment Edited) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190182#comment-13190182 ] Wade Simmons edited comment on THRIFT-1497 at 1/20/12 10:3

[jira] [Commented] (THRIFT-1353) Switch to performance branch, get rid of BinaryParser

2012-01-20 Thread Wade Simmons (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190177#comment-13190177 ] Wade Simmons commented on THRIFT-1353: -- All of the feedback I've heard is

[jira] [Updated] (THRIFT-1434) Node.js Thrift compiler fails to generate server code using inheritance

2011-11-21 Thread Wade Simmons (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-1434: - Attachment: 0001-We-need-to-use-Thrift.inherits-for-Processors-like-w.patch The current

[jira] [Commented] (THRIFT-1353) Switch to performance branch, get rid of BinaryParser

2011-10-05 Thread Wade Simmons (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121349#comment-13121349 ] Wade Simmons commented on THRIFT-1353: -- I merged node-thrift 0.7.0 wit

[jira] [Commented] (THRIFT-1353) Switch to performance branch, get rid of BinaryParser

2011-09-22 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113032#comment-13113032 ] Wade Simmons commented on THRIFT-1353: -- I'm the author of this upstream br

[jira] [Commented] (THRIFT-1267) Node.js can't throw exceptions.

2011-08-23 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089730#comment-13089730 ] Wade Simmons commented on THRIFT-1267: -- It looks like Russell Haering has a

[jira] [Commented] (THRIFT-1277) Node.js serializes false booleans as null

2011-08-18 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087109#comment-13087109 ] Wade Simmons commented on THRIFT-1277: -- This will serialize `undefined` as `

[jira] [Commented] (THRIFT-1267) Node.js can't throw exceptions.

2011-08-17 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086436#comment-13086436 ] Wade Simmons commented on THRIFT-1267: -- I wonder if we should instead ma

[jira] [Commented] (THRIFT-1134) Node.js test suite

2011-04-08 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017669#comment-13017669 ] Wade Simmons commented on THRIFT-1134: -- I can take this on since I wrote

[jira] [Updated] (THRIFT-1129) Add BufferedTransport (non-framed) to Node.js library

2011-04-03 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-1129: - Attachment: thrift_nodejs_buffered_transport.patch Add BufferedTransport >

[jira] [Created] (THRIFT-1129) Add BufferedTransport (non-framed) to Node.js library

2011-04-03 Thread Wade Simmons (JIRA)
: JavaScript - Library Reporter: Wade Simmons Attachments: thrift_nodejs_buffered_transport.patch This patch adds non-framed transport support for the Node.js library (previously, only FramedTransport was supported). Patch created from Github pull request: https://github.com

[jira] Commented: (THRIFT-1044) Fix JavaScript inheritance

2011-02-16 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995413#comment-12995413 ] Wade Simmons commented on THRIFT-1044: -- This patch looks fine to me. I'

[jira] Commented: (THRIFT-1045) Support "included"ed thrift files

2011-02-16 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995411#comment-12995411 ] Wade Simmons commented on THRIFT-1045: -- I just tested this patch with the Nod

Re: [VOTE] Thrift 0.6.0 RC2

2011-01-30 Thread Wade Simmons
On Sun, Jan 30, 2011 at 6:44 PM, Jake Luciani wrote: > I propose that we accept > http://people.apache.org/~jake/thrift-0.6.0-rc2.tar.gz >  as > the official Thrift 0.6.0 release. I get an HTTP Forbidden error when I try to download

Re: [VOTE] Thrift 0.6.0 RC1

2011-01-26 Thread Wade Simmons
door with known issues. - https://issues.apache.org/jira/browse/THRIFT-1042 - https://issues.apache.org/jira/browse/THRIFT-1043 - https://issues.apache.org/jira/browse/THRIFT-1044 - https://issues.apache.org/jira/browse/THRIFT-1045 Thanks, Wade -- Wade Simmons

[jira] Created: (THRIFT-1045) Support "included"ed thrift files

2011-01-21 Thread Wade Simmons (JIRA)
s Versions: 0.6 Reporter: Wade Simmons Attachments: nodejs-thrift-imports.patch The current version of the Node.js compiler doesn't support thrift files that "include" other thrift files. This patch imports and references them properly. -- This message is automa

[jira] Updated: (THRIFT-1045) Support "included"ed thrift files

2011-01-21 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-1045: - Attachment: nodejs-thrift-imports.patch if the .thrift file "include"s another t

[jira] Updated: (THRIFT-1044) Fix JavaScript inheritance

2011-01-21 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-1044: - Attachment: Fix-JavaScript-inheritance.patch Fix JavaScript inheritance. For Node.js we can

[jira] Created: (THRIFT-1044) Fix JavaScript inheritance

2011-01-21 Thread Wade Simmons (JIRA)
Versions: 0.6 Reporter: Wade Simmons The current JavaScript compiler has a pretty simple way of doing inheritance (just copies the prototype fields over). Node.js has a helper method for this (sys.inherits) and there are easier ways to do it in the browser too. This patch makes it easy

[jira] Updated: (THRIFT-1043) Fix how the length of a map is calculated

2011-01-21 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-1043: - Attachment: Fix-how-the-length-of-a-map-is-calculated.patch Fix how the length of a map is

[jira] Created: (THRIFT-1043) Fix how the length of a map is calculated

2011-01-21 Thread Wade Simmons (JIRA)
, JavaScript - Library Affects Versions: 0.5, 0.6 Reporter: Wade Simmons The current version of the JavaScript compiler uses map.length to calculate the size of a map, but this is not correct (this only works for arrays). This patch uses `Object.keys(map).length` for Node.js and a more

[jira] Updated: (THRIFT-1042) Fix TApplicationException.read

2011-01-21 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-1042: - Attachment: fix-TApplicationException.read.patch fix TApplicationException.read >

[jira] Created: (THRIFT-1042) Fix TApplicationException.read

2011-01-21 Thread Wade Simmons (JIRA)
Reporter: Wade Simmons The TApplicationException.read method had some copy/paste artifacts that prevented it from populating properly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.

[jira] Commented: (THRIFT-1033) Node.js language target

2011-01-19 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984017#action_12984017 ] Wade Simmons commented on THRIFT-1033: -- I found a few bugs with serializing maps

[jira] Issue Comment Edited: (THRIFT-1033) Node.js language target

2011-01-19 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984017#action_12984017 ] Wade Simmons edited comment on THRIFT-1033 at 1/19/11 11:0

[jira] Updated: (THRIFT-1033) Node.js language target

2011-01-07 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-1033: - Attachment: thrift_nodejs_lib.patch Here is a patch the imports the node-thrift library into

[jira] Updated: (THRIFT-1033) Node.js language target

2011-01-07 Thread Wade Simmons (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wade Simmons updated THRIFT-1033: - Attachment: thrift_nodejs.patch > Node.js language tar

[jira] Created: (THRIFT-1033) Node.js language target

2011-01-07 Thread Wade Simmons (JIRA)
Node.js language target --- Key: THRIFT-1033 URL: https://issues.apache.org/jira/browse/THRIFT-1033 Project: Thrift Issue Type: New Feature Reporter: Wade Simmons Attachments: thrift_nodejs.patch