[GitHub] thrift pull request: THRIFT-2941

2015-01-12 Thread captncraig
GitHub user captncraig opened a pull request: https://github.com/apache/thrift/pull/356 THRIFT-2941 https://issues.apache.org/jira/browse/THRIFT-2941 You can merge this pull request into a Git repository by running: $ git pull https://github.com/captncraig/thrift THRIFT-2941

[GitHub] thrift pull request: THRIFT-2824

2014-11-14 Thread captncraig
GitHub user captncraig opened a pull request: https://github.com/apache/thrift/pull/266 THRIFT-2824 https://issues.apache.org/jira/browse/THRIFT-2824 We use the html generator to create and publish documentation for our services. We primarily use the program level doctext

[GitHub] thrift pull request: Backout

2014-11-10 Thread captncraig
GitHub user captncraig opened a pull request: https://github.com/apache/thrift/pull/259 Backout It has been pointed out to me that https://github.com/apache/thrift/pull/249 was wrong. It was not needed to allow server sockets to use buffering. The correct way is to pass in a

[GitHub] thrift pull request: Go Library - Make remote socket address acces...

2014-11-10 Thread captncraig
GitHub user captncraig opened a pull request: https://github.com/apache/thrift/pull/255 Go Library - Make remote socket address accessible In my server I would like to log the remote ip address of incoming connections. This patch makes the addr available on TSocket via an accessor

[GitHub] thrift pull request: Allowing use of buffered sockets in go server

2014-10-20 Thread captncraig
GitHub user captncraig opened a pull request: https://github.com/apache/thrift/pull/249 Allowing use of buffered sockets in go server There is currently no way in a go server to use buffered sockets. Failing to do so decreases performance significantly in my tests. I

[GitHub] thrift pull request: C# - reduce number of server exceptions

2014-09-19 Thread captncraig
Github user captncraig commented on the pull request: https://github.com/apache/thrift/pull/177#issuecomment-56225456 Yeah, I agree that scenario sucks. The problem is, I am not sure that all of the transports have a way to really do peek. TcpSocket for example only has a Read

[GitHub] thrift pull request: C# - reduce number of server exceptions

2014-08-08 Thread captncraig
GitHub user captncraig opened a pull request: https://github.com/apache/thrift/pull/177 C# - reduce number of server exceptions The current server implementation reads in a loop until the client closes, at which point an exception is thrown by the processor/transport and caught by