GitHub user davinchia opened a pull request:
https://github.com/apache/thrift/pull/1311
Fix for constant assignments to optional fields in Go.
As per ticket https://issues.apache.org/jira/browse/THRIFT-4253.
As I dug through the code I realised the problem was not only
Github user davinchia commented on the issue:
https://github.com/apache/thrift/pull/1311
https://stackoverflow.com/questions/30716354/how-do-i-do-a-literal-int64-in-go
is a good summary of the different ways to assign constant values in Go.
I decided to use an anonymous
Github user davinchia commented on the issue:
https://github.com/apache/thrift/pull/1311
@Jens-G
This is the first time I'm writing production C++ code so please feel free
to tear this apart.
---
If your project is set up for it, you can reply to this email and have your
Github user davinchia commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1311#discussion_r129124617
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -424,6 +424,52 @@ bool t_go_generator::is_pointer_field(t_field* tfield,
bool
Github user davinchia commented on the issue:
https://github.com/apache/thrift/pull/1311
@Jens-G Github must have hidden my comments. My latest commit combined the
functions and removed the toString function as per your suggestions.
Not sure why one of the integration tests