Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Perfect, now fails on things not related to my changes.
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Now seems ok. This is another big change. So I will try to do cross tests
after. Meanwhile I cross validated with Java. Already in production with this
stuff...
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
What's multic and multi. What's the difference?
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
@jeking3 I don't think binary and multi server can be compatible. In fact I
see it failing everytime and this is why I didn't set your protocol
recommendations.
Let me expla
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
What I'm thinking looking at Java implementation is that on c_glib we can
set a property in the processor to define what's the default handler to be get
in case of a not multi client.
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Ok. Fixed a bug in the test client. And added the default protocol for the
multiplexed. That way the first registered protocol becomes default. This
allows you to use the multi without much hassle
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Yes, there are a couple of them on the wild. I will take a look ASAP. I had
three of my servers broke at the same time this week and I'm was crazy until
today to bring them up again. Give
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
@jeking3 It will fail because binary protocols doesn't use limit string
parameter. Can you remove them from tests since it's not supported.
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Someone broke the build system or there's a patch that made things worse.
Anyway. Check tests manually. I think it's ready to be merged. In fact what I
solved in last commit was not rel
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1191
Jus great, thank you!
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
@jeking3 Do you think it would be hard to resolve? If you need me to do
something. Can you point me the right direction. Remember to remove the binary
protocols from the cross tests since they
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Rebased and lots of fixes added. Crossing fingers.
I should opened a new issue but since all bug fixing were discovered while
doing this incident I took the opportunity to fix everything here.
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
I finally removed the binary protocol from the list of the limits feature
tests. I don't know if I did right but it seems so. This bug also contains
important bugfixes for the conne
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Please merge it or give me a reason to not do it.
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
@jeking3 I don't know why some compilations fails. Maybe you could check
because I don't know about what travis is doing. For me seems ok.
Our tests are now ok. I added some fixes to
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Unfortunately it doesn't work for me on the second command.
dockerrun ubuntu-xenial
Unable to find image 'ubuntu-xenial:latest' locally
docker: Error response from dae
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
With the new image build/docker/scripts/autotools.sh ran ok.
I'm running the other... But no error sofar...
I will try to add -pendantic to the compilation if it doesn't have it in my
host
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Ok I was unable to run as you said in travis. But the errors the code was
giving was because somewhere in build system is configured to compile some
binaries as C90. The errors where mostly
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
@jeking3 It doesn't fail for me, even in the docker container. Please
review and merge.
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
4197.6 Fails... I'm done. Don't know what else to do.
Please check what is it...
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Yes but this seems to be in other languages that are not in my scope. So it
should be others that fix them. So I think it's good enough for now. Can you
merge it? And maybe open a new bug to
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
@jeking3 I don't think is an error, but that all this cross tests are
directly not supported. No all protocols are implemented.
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
What I'm telling you is that I need help if you want to fix everything on
this language. I don't have all the time to implement the full stack. This is
an implementation of the processo
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
In fact @jeking3 Some of the failures are not related to this issue. So
please don't ask me to fix them as part of this issue. One of them is caused in
the Java Server because the exce
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Hi @jeking3 I think at the end it was part of the test client... What do
you think? It worth it merge it?
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Hi @jeking3 can you merge please?
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Can it be because the SSL server. That's not implemented on c_glib?
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
But I don't know about the languages that are failing. This is why I told
you to open other issue and merge this.
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Just curious that The error messages I get are different. In fact they got
blocked on the RS (Rust?) client, at least it seems to.
---
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
I tried to debug the Rust thing. But it seems is not receiving the response
from c_glib testNest in my case. I debugged the server and the response is
sent, and flushed. So I don't catch why
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1361
Hi @jeking3 it was a hard feature to merge... Hope we will do finer next
time. Thank you for your continued support.
---
101 - 131 of 131 matches
Mail list logo
