[GitHub] thrift pull request: Thrift 2905 & - Modern Objective-C & Swift co...

2015-07-10 Thread jimspeth
Github user jimspeth commented on the pull request: https://github.com/apache/thrift/pull/539#issuecomment-120408184 I love it. A couple of minor changes that will make the header files even more readable: * Remove the `getter=` and `setter=` from the property

[GitHub] thrift pull request: THRIFT-2897: Implement hash and isEqual: meth...

2014-12-17 Thread jimspeth
GitHub user jimspeth opened a pull request: https://github.com/apache/thrift/pull/330 THRIFT-2897: Implement hash and isEqual: methods. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dwnld/thrift THRIFT-2897 Alternatively you

[GitHub] thrift pull request: THRIFT-2899: Prefix enum values with the Coco...

2014-12-17 Thread jimspeth
GitHub user jimspeth opened a pull request: https://github.com/apache/thrift/pull/328 THRIFT-2899: Prefix enum values with the Cocoa namespace. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dwnld/thrift THRIFT-2899

[GitHub] thrift pull request: THRIFT-2898: Generated classes implement the ...

2014-12-17 Thread jimspeth
GitHub user jimspeth opened a pull request: https://github.com/apache/thrift/pull/327 THRIFT-2898: Generated classes implement the NSCopying protocol. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dwnld/thrift THRIFT-2898

[GitHub] thrift pull request: Added support for a custom base class.

2014-12-17 Thread jimspeth
GitHub user jimspeth opened a pull request: https://github.com/apache/thrift/pull/326 Added support for a custom base class. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dwnld/thrift THRIFT-2896 Alternatively you can review

[GitHub] thrift pull request: Typedef enums using NS_ENUM.

2014-12-17 Thread jimspeth
GitHub user jimspeth opened a pull request: https://github.com/apache/thrift/pull/325 Typedef enums using NS_ENUM. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dwnld/thrift THRIFT-2561 Alternatively you can review and apply