[GitHub] thrift issue #1082: THRIFT-3828 In cmake avoid use of both quoted paths and ...

2016-11-14 Thread jmesmon
Github user jmesmon commented on the issue: https://github.com/apache/thrift/pull/1082 Issue was observed in yocto (aka open-embedded) when building for target. It likely requires cross compilation (and thus /usr/include is actually some other path) to trigger. --- If your project

[GitHub] thrift pull request #1085: THRIFT-3831 in test/cpp explicitly use `signed ch...

2016-09-09 Thread jmesmon
GitHub user jmesmon opened a pull request: https://github.com/apache/thrift/pull/1085 THRIFT-3831 in test/cpp explicitly use `signed char` `char`'s signed-ness is implimentation dependent, and in the case where `char` was not signed, we previously recieved errors like

[GitHub] thrift pull request #1082: THRIFT-3828 In cmake avoid use of both quoted pat...

2016-09-07 Thread jmesmon
GitHub user jmesmon opened a pull request: https://github.com/apache/thrift/pull/1082 THRIFT-3828 In cmake avoid use of both quoted paths and SYSTEM with include_directories() This allows us to avoid issues where there are no paths to be added to the include path