[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes

2018-02-09 Thread jparise
Github user jparise commented on the issue: https://github.com/apache/thrift/pull/1474 Coming back to the original proposed change, is this likely or unlikely to be merged? I don't think I fully understand @jfarrell's "this change must originate from Facebook" r

[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes

2018-01-19 Thread jparise
Github user jparise commented on the issue: https://github.com/apache/thrift/pull/1474 I'm not affiliated with either project, but I work in an environment that uses multiple Thrift implementations, so interoperability is important to us. We're specifically interested in using some

[GitHub] thrift pull request #1474: Recognize fbthrift TApplicationException codes

2018-01-17 Thread jparise
GitHub user jparise opened a pull request: https://github.com/apache/thrift/pull/1474 Recognize fbthrift TApplicationException codes fbthrift defines [three additional TApplicationException error codes](https://github.com/facebook/fbthrift/blob/master/thrift/lib/cpp

[GitHub] thrift pull request: THRIFT-3214 Add Erlang option for using maps ...

2015-07-01 Thread jparise
Github user jparise commented on a diff in the pull request: https://github.com/apache/thrift/pull/535#discussion_r33729457 --- Diff: compiler/cpp/src/generate/t_erl_generator.cc --- @@ -55,6 +55,7 @@ class t_erl_generator : public t_generator { out_dir_base_ = gen-erl

[GitHub] thrift pull request: Directly link libboost_unit_test_framework.a.

2014-12-19 Thread jparise
GitHub user jparise opened a pull request: https://github.com/apache/thrift/pull/333 Directly link libboost_unit_test_framework.a. Not all linkers support the `-l:libfoo.a` syntax (notably ld(1) on Mac OS X). For full compatibility, we want to link directly against

[GitHub] thrift pull request: Don't define ntohll() if it is already define...

2014-12-19 Thread jparise
GitHub user jparise opened a pull request: https://github.com/apache/thrift/pull/334 Don't define ntohll() if it is already defined. Fixes [THRIFT-2907](https://issues.apache.org/jira/browse/THRIFT-2907) You can merge this pull request into a Git repository by running: $ git

[GitHub] thrift pull request: THRIFT-2887 Respect --with-openssl when build...

2014-12-15 Thread jparise
Github user jparise closed the pull request at: https://github.com/apache/thrift/pull/316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: THRIFT-2887 Respect --with-openssl when build...

2014-12-15 Thread jparise
Github user jparise commented on the pull request: https://github.com/apache/thrift/pull/316#issuecomment-67031649 Merged as a195a2574ef9729da9be65283d29b87e39e8ebcb. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] thrift pull request: Respect --with-openssl when building C++ supp...

2014-12-11 Thread jparise
GitHub user jparise opened a pull request: https://github.com/apache/thrift/pull/316 Respect --with-openssl when building C++ support. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jparise/thrift thrift-2887 Alternatively you