GitHub user prashantv opened a pull request:
https://github.com/apache/thrift/pull/624
Use enums instead of multiple boolean arguments
Multiple boolean arguments in a function call leads to unreadable code.
E.g
```cpp
generate_deserialize_field(out, , true, "&qu
GitHub user prashantv opened a pull request:
https://github.com/apache/thrift/pull/625
Fix word-extraction substr bug in initialism code
Initialisms were not handled in the second word or later. E.g. for the
given Thrift file,
```thrift
service S {
void get_id
Github user prashantv commented on the pull request:
https://github.com/apache/thrift/pull/624#issuecomment-143065168
Thanks for the feedback - I was thinking about a struct approach, but
because it's not easy to create a struct inline, I avoided that.
As you said, flags work
GitHub user prashantv opened a pull request:
https://github.com/apache/thrift/pull/571
Close previous response body on flush. (THRIFT-3277)
Connections were being leaked as Flush created new responses without
closing the previous response body.
See THRIFT-3277 for more
GitHub user prashantv opened a pull request:
https://github.com/apache/thrift/pull/518
On non-200 HTTP responses, the body was not being closed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prashantv/thrift master
Github user prashantv commented on the pull request:
https://github.com/apache/thrift/pull/517#issuecomment-111205380
@i Just started a PR for the same issue, didn't see your fix.
I think it's better to not set p.Response, since it affects other code
(IsOpen returns true, Read
