[jira] [Commented] (THRIFT-4099) Auto-derive Hash for generated Rust structs

2017-12-14 Thread Tony Przygienda (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291411#comment-16291411 ] Tony Przygienda commented on THRIFT-4099: - BTW, agree with the OrderedFloat ... Non-comparable

[GitHub] thrift issue #1246: THRIFT-4099: Derive Hash trait for Rust structs

2017-12-14 Thread przygienda
Github user przygienda commented on the issue: https://github.com/apache/thrift/pull/1246 Nah, I'm not AWOL but just completely under water with stuff here and my version here works ;-) ... I agree that we should split the stuff up. I hope to find cycles in new year. Tell me what you

[GitHub] thrift issue #1187: Review for pull up of RUST extended namespace support, a...

2017-04-22 Thread przygienda
Github user przygienda commented on the issue: https://github.com/apache/thrift/pull/1187 Thanks for closing, yes, the work moved to main thrift tracker ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift issue #1187: Review for pull up of RUST extended namespace support, a...

2017-04-09 Thread przygienda
Github user przygienda commented on the issue: https://github.com/apache/thrift/pull/1187 Our MailScanner believes that the attachment to this message sent to you From: p...@zeta2.ch Subject: Re: [apache/thrift] Review for pull up of RUST extended namespace

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

2017-04-07 Thread Tony Przygienda (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961031#comment-15961031 ] Tony Przygienda commented on THRIFT-2945: - didn't forget about it.Had to get the company

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

2017-02-20 Thread Tony Przygienda (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874943#comment-15874943 ] Tony Przygienda commented on THRIFT-2945: - OK, we're in agreement., I'll get to it & come

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

2017-02-16 Thread Tony Przygienda (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869482#comment-15869482 ] Tony Przygienda commented on THRIFT-2945: - OK, rephrased in other points what I read a) we agree

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

2017-02-13 Thread Tony Przygienda (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865263#comment-15865263 ] Tony Przygienda commented on THRIFT-2945: - for 5. I finally found the PassThru solution to mask

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

2017-02-13 Thread Tony Przygienda (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865159#comment-15865159 ] Tony Przygienda commented on THRIFT-2945: - 1. OK, I named it serializable since that's what

[GitHub] thrift issue #1187: Review for pull up of RUST extended namespace support, a...

2017-02-13 Thread przygienda
Github user przygienda commented on the issue: https://github.com/apache/thrift/pull/1187 OK, finished. The patch does * improve the namespace support by allowing to nest Thrift models inside a package now * moves the reading/writing into a proper trait so models can

[GitHub] thrift pull request #1187: Review for pull up extended namespace support, ad...

2017-02-12 Thread przygienda
GitHub user przygienda opened a pull request: https://github.com/apache/thrift/pull/1187 Review for pull up extended namespace support, addition of macros to allow application to macroize over defintions ... Please review initial request here ... You can merge this pull request

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

2017-02-12 Thread Tony Przygienda (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863010#comment-15863010 ] Tony Przygienda commented on THRIFT-2945: - understood, I'm commenting purely in Rust context here

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

2017-02-12 Thread Tony Przygienda (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862911#comment-15862911 ] Tony Przygienda commented on THRIFT-2945: - fantastic work albeit it compltely ruined all my

[GitHub] thrift issue #1137: Implement CONST support

2017-02-05 Thread przygienda
Github user przygienda commented on the issue: https://github.com/apache/thrift/pull/1137 have a first rudimentary implementation of that on my branch. On top added something that allows to plug custom traits into the generated code (I used that to implement over redis-rs a trait

[GitHub] thrift pull request #1137: Implement CONST support

2016-12-07 Thread przygienda
GitHub user przygienda opened a pull request: https://github.com/apache/thrift/pull/1137 Implement CONST support You can merge this pull request into a Git repository by running: $ git pull https://github.com/maximg/thrift dev-rust-thrift Alternatively you can review