[jira] [Comment Edited] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225754#comment-17225754 ] shuo li edited comment on THRIFT-5300 at 11/4/20, 12:51 AM: [~allengeorge] 

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225754#comment-17225754 ] shuo li commented on THRIFT-5300: - [~allengeorge] and [~fishywang]: yes, that is my understanding too.

[jira] [Comment Edited] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225116#comment-17225116 ] shuo li edited comment on THRIFT-5300 at 11/3/20, 3:46 AM: --- {code:java}

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225116#comment-17225116 ] shuo li commented on THRIFT-5300: - {code:java} #[test] fn must_write_small_sized_list_begin() {

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224415#comment-17224415 ] shuo li commented on THRIFT-5300: - [~zeshuai007] I'm confused, while reading code of cpp, in

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224414#comment-17224414 ] shuo li commented on THRIFT-5299: - [~allengeorge] Correct, another workaround could be read u32 which

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223371#comment-17223371 ] shuo li commented on THRIFT-5299: - [~jensg] I've been reading through all the rust code and also other

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222640#comment-17222640 ] shuo li commented on THRIFT-5299: - [~jensg] thanks for reply, I think the problem is well described and

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222639#comment-17222639 ] shuo li commented on THRIFT-5299: - [~allengeorge] shed some light on this issue too? :P > rs

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222637#comment-17222637 ] shuo li commented on THRIFT-5300: - [~allengeorge] I double checked other implementations (golang cpp

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222636#comment-17222636 ] shuo li commented on THRIFT-5299: - I opened an issue on integer-encoding:

[jira] [Updated] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuo li updated THRIFT-5299: Description: While reviewing code, I discovered a bug in compact protocol. The seq_id in message header

[jira] [Created] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

shuo li created THRIFT-5300: --- Summary: rs compact protocol collection elem type to ttype mapping wrong Key: THRIFT-5300 URL: https://issues.apache.org/jira/browse/THRIFT-5300 Project: Thrift

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221988#comment-17221988 ] shuo li commented on THRIFT-5300: -

[jira] [Reopened] (THRIFT-5299) rs implementation compact protocol varint implementation is wrong

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuo li reopened THRIFT-5299: - reopen it, the sequence number's impl is wrong, which uses zigzag encoding.  > rs implementation compact

[jira] [Closed] (THRIFT-5299) rs implementation compact protocol varint implementation is wrong

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuo li closed THRIFT-5299. --- Resolution: Won't Fix After reading other lang implementations, current impl is correct, though the

[jira] [Created] (THRIFT-5299) rs implementation compact protocol varint implementation is wrong

shuo li created THRIFT-5299: --- Summary: rs implementation compact protocol varint implementation is wrong Key: THRIFT-5299 URL: https://issues.apache.org/jira/browse/THRIFT-5299 Project: Thrift