[GitHub] thrift pull request: Thrift 3383 i64 related warnings

2015-12-30 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/764 Thrift 3383 i64 related warnings These changes reduce the number of compiler warnings, and eliminate all warnings related to 64-bit values, generated when building the C (GLib) test suite on a

[GitHub] thrift pull request: Thrift 3512 c glib build fails due to missing...

2015-12-29 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/763 Thrift 3512 c glib build fails due to missing features.h Include `features.h` (in `testbinaryprotocol.c`) only only platforms that use GNU libc. This fixes THRIFT-3512 and assumes the

[GitHub] thrift pull request: THRIFT-3498 C++ library assumes optional func...

2015-12-21 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/754 THRIFT-3498 C++ library assumes optional function pthread_attr_setschedpolicy is available This patch allows Thrift to build on Haiku and other systems that do not implement POSIX's t

[GitHub] thrift pull request: THRIFT-3497 Build fails with "invalid use of ...

2015-12-21 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/753 THRIFT-3497 Build fails with "invalid use of incomplete type" This change fixes an "invalid use of incomplete type" compiler error referring to `struct timeval` wh

[GitHub] thrift pull request: THRIFT-3386 misc. warnings with make check

2015-12-20 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/751 THRIFT-3386 misc. warnings with make check At long last, here's a patch that adds explicit casts to the C (GLib) test code to prevent compiler warnings during `make check`. You can merge

[GitHub] thrift pull request: THRIFT-3178: c_glib does not compile

2015-08-07 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/581 THRIFT-3178: c_glib does not compile These changes allow Hypertable's Thrift interface to be compiled by the C (GLib) compiler by correcting the way the compiler handles "com

[GitHub] thrift pull request: THRIFT-2832: c_glib: Handle string lists corr...

2015-08-05 Thread simonsouth
Github user simonsouth closed the pull request at: https://github.com/apache/thrift/pull/578 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2832: c_glib: Handle string lists corr...

2015-08-04 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/578 THRIFT-2832: c_glib: Handle string lists correctly These commits - Add a unit test for C (GLib) that covers containers (initially only string lists, i.e. variables of type `list`) used

[GitHub] thrift pull request: THRIFT-3288 c glib build unit tests with all ...

2015-08-03 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/577 THRIFT-3288 c glib build unit tests with all warnings enabled **Note:** This pull request includes the changes from request #576 (to fix THRIFT-3285), which should be applied first

[GitHub] thrift pull request: THRIFT-3285 c glib build library with all war...

2015-08-01 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/576 THRIFT-3285 c glib build library with all warnings enabled These changes - Update the C (GLib) library's makefile so the AM_CPPFLAGS and AM_CFLAGS variables are used correctly acco

[GitHub] thrift pull request: c_glib: Compiler: Omit processing-function de...

2015-08-01 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/575 c_glib: Compiler: Omit processing-function defs for empty services With this change the compiler omits the processing-function-definition array for a service with no methods, corresponding to

[GitHub] thrift pull request: THRIFT-3283: c_glib: Tutorial: Fix uninitiali...

2015-07-31 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/574 THRIFT-3283: c_glib: Tutorial: Fix uninitialized-variable warning This patch makes the tutorial server initialize an error variable to NULL before using it, which resolves a GLib warning printed

[GitHub] thrift pull request: THRIFT-3260 multiple warnings in c glib tutor...

2015-07-31 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/573 THRIFT-3260 multiple warnings in c glib tutorial Here are additional changes that should really and truly resolve all the warnings generated when building the c_glib tutorial: Compiler

[GitHub] thrift pull request: THRIFT-3260 multiple warnings in c glib tutor...

2015-07-30 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/572 THRIFT-3260 multiple warnings in c glib tutorial This patch resolves the remaining warning messages output by the compiler when building the C (GLib) tutorial. It - Modifies the

[GitHub] thrift pull request: c_glib: Compiler: Do not try to convert betwe...

2015-07-28 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/568 c_glib: Compiler: Do not try to convert between function, void pointers This patch corrects THRIFT-3273 by introducing the notion of a "processing-function definition", a stru

[GitHub] thrift pull request: c_glib: Compiler: Do not try to convert betwe...

2015-07-28 Thread simonsouth
Github user simonsouth closed the pull request at: https://github.com/apache/thrift/pull/567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: c_glib: Compiler: Do not try to convert betwe...

2015-07-28 Thread simonsouth
GitHub user simonsouth opened a pull request: https://github.com/apache/thrift/pull/567 c_glib: Compiler: Do not try to convert between function, void pointers This patch corrects THRIFT-3272 by introducing the notion of a "processing-function definition", a stru