[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

Github user snikulov commented on the pull request: https://github.com/apache/thrift/pull/598#issuecomment-138227255 @nsuke updated pull request per your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

Github user snikulov commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38620073 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

Github user snikulov commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38619873 --- Diff: build/cmake/DefineOptions.cmake --- @@ -62,8 +62,10 @@ endif() find_package(OpenSSL QUIET) CMAKE_DEPENDENT_OPTION(WITH_OPENSSL "

[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

GitHub user snikulov opened a pull request: https://github.com/apache/thrift/pull/598 cmake // fixes for std/boost::thread detection; security test; qt test Hello All! Relates to https://issues.apache.org/jira/browse/THRIFT-2850 1. Will use BOOST if not explicitly

[GitHub] thrift pull request: autotools // Use Boost C++ >= 1.53.0

Github user snikulov commented on the pull request: https://github.com/apache/thrift/pull/376#issuecomment-74487449 Merged https://github.com/apache/thrift/commit/283899bf9a8de07522b6507dfd0f6ab70d5a7147 Thanks to @bufferoverflow --- If your project is set up for it, you can

[GitHub] thrift pull request: autotools // Use Boost C++ >= 1.53.0

Github user snikulov closed the pull request at: https://github.com/apache/thrift/pull/376 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: autotools // Use Boost C++ >= 1.53.0

GitHub user snikulov opened a pull request: https://github.com/apache/thrift/pull/376 autotools // Use Boost C++ >= 1.53.0 - Updated autotools to search Boost C++ version equal to 1.53.0 or higher. - Updated docs to reflect this change - Fixed compilation issue w

[GitHub] thrift pull request: cmake // build // fixed java library build en...

Github user snikulov closed the pull request at: https://github.com/apache/thrift/pull/365 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: cmake // build // fixed java library build en...

Github user snikulov commented on the pull request: https://github.com/apache/thrift/pull/365#issuecomment-72654403 Merged to master https://github.com/apache/thrift/commit/9d8c1bf6f62c22c13c5b6b4da51b1de1a9d27339 --- If your project is set up for it, you can reply to this email and

[GitHub] thrift pull request: cmake // build // fixed java library build en...

Github user snikulov commented on the pull request: https://github.com/apache/thrift/pull/365#issuecomment-72184044 Related to https://issues.apache.org/jira/browse/THRIFT-2850 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift pull request: cmake // build // fixed java library build en...

GitHub user snikulov opened a pull request: https://github.com/apache/thrift/pull/365 cmake // build // fixed java library build enabler Hello, Here the fix for case when jdk is installed, but to Ant. Since Ant is required to build java library, I move Ant search to

[GitHub] thrift pull request: C++: fixed UT compilation on Windows

Github user snikulov commented on the pull request: https://github.com/apache/thrift/pull/207#issuecomment-57276868 Submitted https://issues.apache.org/jira/browse/THRIFT-2745 Re-based with latest master. --- If your project is set up for it, you can reply to this email and

[GitHub] thrift pull request: C++: fixed UT compilation on Windows

GitHub user snikulov opened a pull request: https://github.com/apache/thrift/pull/207 C++: fixed UT compilation on Windows Hello, Small fixes for UT compilation - renamed variable (it again clashes with windows.h macro) - changed usleep to THRIFT_SLEEP_USEC You can

[GitHub] thrift pull request: Tree/Recursive struct support in thrift

Github user snikulov commented on the pull request: https://github.com/apache/thrift/pull/84#issuecomment-39987106 @djwatson Yes. my _types.cpp is linked in. But as @henrique mentioned _presult and _pargs destructor's are not generated and thus linker gives error. --- If

[GitHub] thrift pull request: Tree/Recursive struct support in thrift

Github user snikulov commented on the pull request: https://github.com/apache/thrift/pull/84#issuecomment-39949481 This change breaks c++ generation. After this change in compiler/cpp/src/generate/t_cpp_generator.cc - indent() << "virtual ~" <