Github user snikulov commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/598#discussion_r38620073
  
    --- Diff: lib/cpp/test/qt/CMakeLists.txt ---
    @@ -18,11 +18,15 @@
     #
     
     set(CMAKE_AUTOMOC ON)
    -find_package(Qt5 REQUIRED COMPONENTS Test)
    +find_package(Qt5 REQUIRED COMPONENTS Test Network)
     set(TQTcpServerTest_Qt5_SOURCES
         TQTcpServerTest.cpp
     )
     add_executable(TQTcpServerTest_Qt5 ${TQTcpServerTest_Qt5_SOURCES})
    -target_link_libraries(TQTcpServerTest_Qt5 testgencpp_cob thriftqt5 thrift 
Qt5::Test)
    +target_link_libraries(TQTcpServerTest_Qt5 testgencpp_cob)
    +LINK_AGAINST_THRIFT_LIBRARY(TQTcpServerTest_Qt5 thriftqt5)
    +LINK_AGAINST_THRIFT_LIBRARY(TQTcpServerTest_Qt5 thrift)
    +qt5_use_modules(TQTcpServerTest_Qt5 Test Network)
    --- End diff --
    
    @nsuke Yep. But this was related to my laziness :)
    qt5_use_modules also set includes. Error was related to include issue and 
LINK_AGAINST...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to