[GitHub] thrift pull request: THRIFT-3560: C++: declared TTransport::isOpen...

2016-01-20 Thread szenker
Github user szenker commented on the pull request: https://github.com/apache/thrift/pull/798#issuecomment-173338811 With the term "pipelining" I mean the following in this context: 1.) A client is allowed to send out a consecutive request even before it has received th

[GitHub] thrift pull request: THRIFT-3560: C++: declared TTransport::isOpen...

2016-01-20 Thread szenker
Github user szenker commented on the pull request: https://github.com/apache/thrift/pull/798#issuecomment-173337036 Adding the const keyword is not just syntactical sugar. It requires users which derive from TTransport to be more strict when they implement their own version of isOpen

[GitHub] thrift pull request: THRIFT-3564: potential core dump in TQTcpServ...

2016-01-19 Thread szenker
Github user szenker closed the pull request at: https://github.com/apache/thrift/pull/802 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3566: fixed TQTcpServerTest - it was n...

2016-01-19 Thread szenker
Github user szenker closed the pull request at: https://github.com/apache/thrift/pull/804 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3566: fixed TQTcpServerTest - it was n...

2016-01-18 Thread szenker
GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/804 THRIFT-3566: fixed TQTcpServerTest - it was never executed and working You can merge this pull request into a Git repository by running: $ git pull https://github.com/szenker/thrift THRIFT

[GitHub] thrift pull request: THRIFT-3565: C++: declared T{Async}Processor:...

2016-01-18 Thread szenker
GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/803 THRIFT-3565: C++: declared T{Async}Processor::getEventHandler() as const member functions You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] thrift pull request: THRIFT-3564: potential core dump in TQTcpServ...

2016-01-18 Thread szenker
GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/802 THRIFT-3564: potential core dump in TQTcpServer TQTcpServer: it's not allowed to delete the sender of a Qt signal (QTcpSocket) while executing one of its slots. This could happen in TQTcpS

[GitHub] thrift pull request: THRIFT-3563: C++/Qt: removed usage of macro Q...

2016-01-18 Thread szenker
GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/801 THRIFT-3563: C++/Qt: removed usage of macro QT_PREPEND_NAMESPACE() as it wasn't use consequently for all Qt types, e.g. it cannot be combined with shared_ptr<> You can merge this pull r

[GitHub] thrift pull request: THRIFT-3562: C++: removed unused TEventServer

2016-01-18 Thread szenker
GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/800 THRIFT-3562: C++: removed unused TEventServer You can merge this pull request into a Git repository by running: $ git pull https://github.com/szenker/thrift THRIFT-3562 Alternatively you can

[GitHub] thrift pull request: C++/Qt: make use of Q_DISABLE_COPY() to get r...

2016-01-18 Thread szenker
GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/799 C++/Qt: make use of Q_DISABLE_COPY() to get rid of copy ctor and assignment operator … You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] thrift pull request: C++: declared TTransport::isOpen() and TTrans...

2016-01-18 Thread szenker
GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/798 C++: declared TTransport::isOpen() and TTransport::getOrigin() as const member functions Also TTransport::peek() should be const in my opinion, but this requires some refactoring. You can merge

[GitHub] thrift pull request: Thrift 3496: C++: Cob style client fails when...

2015-12-21 Thread szenker
GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/752 Thrift 3496: C++: Cob style client fails when sending a consecutive request see THRIFT-3496 You can merge this pull request into a Git repository by running: $ git pull https://github.com