[GitHub] [thrift] emmenlau commented on pull request #2032: THRIFT-5116: Update NodeJS to supported version on Ubuntu Xenial

2020-04-24 Thread GitBox
emmenlau commented on pull request #2032: URL: https://github.com/apache/thrift/pull/2032#issuecomment-618958494 Dammit, you are right! Thanks. Slightly off-topic, I think the comments in the Dockerfile should really be changed. I've had good experience with adding comments in

[GitHub] [thrift] emmenlau commented on pull request #2032: THRIFT-5116: Update NodeJS to supported version on Ubuntu Xenial

2020-04-24 Thread GitBox
emmenlau commented on pull request #2032: URL: https://github.com/apache/thrift/pull/2032#issuecomment-618924107 > Unfortunately this seems to have broken Travis: > > > Error response from daemon: Dockerfile parse error line 60: unknown instruction: APT-ADD-REPOSITORY > > The

[GitHub] [thrift] emmenlau commented on pull request #2032: THRIFT-5116: Update NodeJS to supported version on Ubuntu Xenial

2020-04-24 Thread GitBox
emmenlau commented on pull request #2032: URL: https://github.com/apache/thrift/pull/2032#issuecomment-618865274 Thanks @dcelasun, fixed now. Please review. This is an automated message from the Apache Git Service. To