Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1269
@jeking3 Yup - just did that. Is there a way to do it automatically, or is
it a manual process (for now)?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1269
Remember to resolve https://issues.apache.org/jira/browse/THRIFT-4187 as
fixed in 0.12.0.
---
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1269
No problem! I'm sorry I was lax and left it so long :/
Looks like the tests passed, so it's good to merge. Not 100% of the
process, so I'll follow up via email.
---
Github user markerickson-wf commented on the issue:
https://github.com/apache/thrift/pull/1269
+1
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1269
I'd suggest waiting to see how the CI build fares given a change was made.
So today is a distinct possibility. Also, you can commit your own changes.
There's no rule against it. :)
---
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1269
@jeking3 Any chance this could be merged? TY!
---
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1269
@jeking3 I've added unit tests around this behavior and enabled more cross
tests! Do you want me to roll that into this PR, or should I create another bug
and PR?
---
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1269
@jeking3 Fixed up the failing tests. Confirming that precross works.
---
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1269
Yup. Will do. I'm a gonna set myself a target to get it done by end of next
week. I've been lax on this :/
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1269
This needs to be rebased and completed.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1269
This needs to be rebased and completed.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1269
Don't worry, I'm just doing my usual "push things forward" bit. :) I got
the backlog down to 52 open PRs, but that's still about 45 too many for my
taste.
---
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1269
Hi James - Iâm really sorry for the delay; slammed at work. Iâll work
on it this weekend.
Again, super sorry about this
From: James E.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1269
@allengeorge if you add framed transport in dart to the cross test, that
would test a lot... but it would not test error conditions such as this one.
Just a reminder, this needs to move forward.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1269
This pull request needs to be completed. *nudge*
---
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1269
@markerickson-wf My bad - I should definitely have run the unit tests. I'll
check them and fix them up. Also, I'll look into how to create a reasonable set
of unit tests for the framed
Github user markerickson-wf commented on the issue:
https://github.com/apache/thrift/pull/1269
@allengeorge I think this approach looks pretty good at my first pass. I
left a couple of comments, and we'll probably want unit tests around the state
transitions to ensure that all paths
Github user markerickson-wf commented on the issue:
https://github.com/apache/thrift/pull/1269
There are a couple of related unit tests that are failing in
`t_socket_transport_test.dart`. You can run `pub run test test/` from the
`lib/dart` directory to see those.
---
If your
18 matches
Mail list logo
