Github user chetmurthy commented on the issue:
https://github.com/apache/thrift/pull/1418
This patch only flxes cpp-cpp (http) failures. B/c the deeper issue is that
the Thrift cpp stack (both client & server) is nonstandard.
I think I mentioned that I could improve this a
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1418
I'm not certain this resolves THRIFT-3877 entirely - your take?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1418
Pulling this into a sandbox to see if it fixes any of the `cpp*http` known
test failures.
---
Github user chetmurthy commented on the issue:
https://github.com/apache/thrift/pull/1418
Right, the "docker run" command fails with:
chet@twitter:~/Hack/thrift-0.10.0/src/forks/thrift$ dockerrun ubuntu-xenial
Unable to find image 'ubuntu-xenial:latest' locally
docker:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1418
@chetmurthy try "Raw Commands for Building with Docker" at that page.
Once you are in a docker container:
build/docker/scripts/autotools.sh runs a "make check" build
Github user chetmurthy commented on the issue:
https://github.com/apache/thrift/pull/1418
OK, I figured out how to fix cmakelists.txt, to get most of the cmake
builds working. But one still fails. Then I tried to set up and run docker,
to debug that. And can't figure out how from
Github user chetmurthy commented on the issue:
https://github.com/apache/thrift/pull/1418
OK, I see that the Travis CMake builds all failed. I figured out how to
run cmake on my laptop, but I have no idea how to add the dependency that
it's asking for.
---
Github user chetmurthy commented on the issue:
https://github.com/apache/thrift/pull/1418
I looked at the AppVeyor logs failing jobs, and cannot see why they failed.
It looks like they just ran outta time? I have no idea what to do to get
these jos to re-run -- could someone
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1418
I think it's fine as-is, except for adding to ThriftTest in this case since
that is a global test thrift file, and you need one local to lib/cpp/test. The
fact you took the time to add a unit test
Github user chetmurthy commented on the issue:
https://github.com/apache/thrift/pull/1418
Will do. Please do suggest any style changes that you think appropriate --
I am *fully* bought-into the idea that a project should have a uniform style,
and even if I were not to agree with
10 matches
Mail list logo
