Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1461
The reasoning for this is that Apache maintains its own master repository;
so pull requests here have to be pulled into the master by a committer, and
then the github mirror updates. If the commit
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1461
> For Thrift, PRs are not merged, just closed. You'll see a commit with you
as the author but someone else as the committer, like these.
Ah got it, good to know thanks!
---
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1461
> GitHub can now automatically squash commits in PRs at merge time
For Thrift, PRs are not merged, just closed. You'll see a commit with you
as the author but someone else as the
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1461
Travis was green so i've squashed it!
FYI for the future: GitHub can now automatically squash commits in PRs at
merge time. If that feature is enabled for the repo it shouldn't be
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1461
Happy to help. Once Travis is all green, please squash your commits so
it'll be easier to merge.
---
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1461
Done ^. Thanks again for all your direction Dcelasun
---
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1461
Exactly.
---
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1461
Good call, so then:
```
func (p *BaseClient) Client_() thrift.TClient {
return p.c
}
```
?
---
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1461
Any capitalized method on the client will potentially conflict with an RPC,
e.g:
```thrift
service Foo {
string C()
}
```
will generate uncompilable code. I suggest
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1461
This is a lot cleaner -- I like it. We still have the same issue with
tests, though, if the base service is in a separate package -- you can't access
the client as `.c` on the base service since
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1461
> So basically the logic would be to only add `c: thrift.TClient` to the
`*Client` struct if `extends.empty()` in the generator?
Exactly.
---
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1461
You're correct that it's a service extending another service; tbh I missed
that too (I'm not the author of the `.thrift` files. I'm also generally new to
thrift so still sorting out what should
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1461
Ah, you have a service extending another service. I missed that. In that
case, I think removing `c thrift.TClient` from `UserServiceClient` (and
constructor functions) is the cleanest option. That
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1461
> Are you getting this second "Base" struct with 0.11 compiler? Because I
can't reproduce.
I've been working off the master branch, but I just tried generation with
0.11
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1461
```go
type MyServiceClient struct {
c thrift.TClient
*MyServiceBaseClient
}
type MyServiceBaseClient struct {
c thrift.TClient
}
```
Github user johnboiles commented on the issue:
https://github.com/apache/thrift/pull/1461
@dcelasun any thoughts on fixing the tests? Looks like
`tutorial/go/src/tutorial/tutorial.go` imports its `BaseClient` from another
package. Since `c` isn't public in that other package, my
16 matches
Mail list logo
