[GitHub] thrift issue #798: THRIFT-3560: C++: declared TTransport::isOpen() and TTran...

2018-03-20 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/798 I am okay making this change for 0.12.0; if you can rebase, squash, and fix up the issues and force push, and if there are any other methods that need the same const correctness, let's do those too.

[GitHub] thrift issue #798: THRIFT-3560: C++: declared TTransport::isOpen() and TTran...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/798 We need to decide if we move forward with this or not. I'm in favor of const correctness here however it is one of those things you need to do from the beginning because it changes the ABI. We