Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/690
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user MartinHaimberger commented on the pull request:
https://github.com/apache/thrift/pull/690#issuecomment-158115251
@jeking3 tests and nonblocking accept connect and close are implemented now
---
If your project is set up for it, you can reply to this email and have your
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/690#issuecomment-158117682
Nice - having a test like this ensures it is working and more importantly
stays working in the future. It's too bad our build infrastructure seems to be
so fragile.
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/690#discussion_r45070910
--- Diff: lib/cpp/src/thrift/transport/TSSLServerSocket.cpp ---
@@ -48,7 +48,12 @@ TSSLServerSocket::TSSLServerSocket(int port,
}
Github user MartinHaimberger commented on a diff in the pull request:
https://github.com/apache/thrift/pull/690#discussion_r45071978
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -659,6 +659,10 @@ shared_ptr
TServerSocket::createSocket(THRIFT_SOCKET clientSocket)
Github user MartinHaimberger commented on the pull request:
https://github.com/apache/thrift/pull/690#issuecomment-157402412
@jeking3 i will also implement the TSSLSocketInterruptTest
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/690#discussion_r45071550
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -659,6 +659,10 @@ shared_ptr
TServerSocket::createSocket(THRIFT_SOCKET clientSocket) {
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/690#issuecomment-157401129
I think the only concern I would have relative to this is that I don't see
a test that exercises the new code. There are tests that exercise all of the
interrupt code
GitHub user MartinHaimberger opened a pull request:
https://github.com/apache/thrift/pull/690
C++ transport: implement interruptable TSSLSocket
- implement interruptable TSSLSocket using non-blocking
sockets and non-blocking bios
- introduce getter getInterruptSocket() in
Github user MartinHaimberger commented on the pull request:
https://github.com/apache/thrift/pull/690#issuecomment-156150828
Build is failing because cabal could not be downloaded and installed
/home/travis/build.sh: line 45: cabal: command not found
The
10 matches
Mail list logo
