Github user marco-m commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28203820
--- Diff: lib/cpp/CMakeLists.txt ---
@@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS)
else()
find_package(Boost 1.53.0 REQUIRED)
endif()
Github user marco-m commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28203837
--- Diff: build/cmake/DefinePlatformSpecifc.cmake ---
@@ -58,8 +58,9 @@ if(MSVC)
endif(WITH_MT)
endif(MSVC)
-# GCC Specific
Github user bufferoverflow commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28203488
--- Diff: build/cmake/DefinePlatformSpecifc.cmake ---
@@ -58,8 +58,9 @@ if(MSVC)
endif(WITH_MT)
endif(MSVC)
-# GCC Specific
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28205720
--- Diff: lib/cpp/CMakeLists.txt ---
@@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS)
else()
find_package(Boost 1.53.0 REQUIRED)
endif()
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28195428
--- Diff: lib/cpp/CMakeLists.txt ---
@@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS)
else()
find_package(Boost 1.53.0 REQUIRED)
endif()
GitHub user marco-m opened a pull request:
https://github.com/apache/thrift/pull/434
Fix THRIFT-3090 (cmake build is broken)
Problem found and fixed on Mac OS X 10.10.3, but at least the link problems
must happen on every OS.
You can merge this pull request into a Git repository
