Github user daurnimator commented on the pull request:
https://github.com/apache/thrift/pull/92#issuecomment-48268728
Sorry @bufferoverflow, I have no need for this library any more. Just took
a quick look at the diff as it passed through my inbox.
---
If your project is set up for
Github user daurnimator commented on a diff in the pull request:
https://github.com/apache/thrift/pull/92#discussion_r13079843
--- Diff: compiler/cpp/src/generate/t_lua_generator.cc ---
@@ -0,0 +1,1226 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user daurnimator commented on a diff in the pull request:
https://github.com/apache/thrift/pull/92#discussion_r13080038
--- Diff: compiler/cpp/src/generate/t_lua_generator.cc ---
@@ -0,0 +1,1226 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/92#issuecomment-44343372
@daurnimator could you provide a patch for this?
https://issues.apache.org/jira/browse/THRIFT-1681
thanks!
-roger
---
If your project is set up
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/92#issuecomment-39585543
Hey @djwatson, thanks for another patch, really appreciate your
contributions back to Apache Thrift. looking at it quickly config check are
good, compiler looks good,
Github user djwatson commented on the pull request:
https://github.com/apache/thrift/pull/92#issuecomment-39603159
These should both be fixed - updated all the headers I found to apache (let
me know if I missed any). Updated the TODO with description and remove name
---
If your
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user djwatson opened a pull request:
https://github.com/apache/thrift/pull/92
THRIFT-1681
LUA thrift library merge from github.com/facebook/fbthrift
Makefile.am builds C components - lua files are just copied as scripts.
Not sure if this is correct?
Test
