Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/210#issuecomment-57613963
closing - those changes are also part of THRIFT-2717
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user hcorg closed the pull request at:
https://github.com/apache/thrift/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hcorg closed the pull request at:
https://github.com/apache/thrift/pull/209
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hcorg commented on the pull request:
https://github.com/apache/thrift/pull/209#issuecomment-55392582
made obsolete by #210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user hcorg opened a pull request:
https://github.com/apache/thrift/pull/210
THRIFT-2692 compiler refactor v2
this pull request contains some 'real' refactoring (of my own previous
contribution) which shows how much adding new tests can help
also I've created some
GitHub user hcorg opened a pull request:
https://github.com/apache/thrift/pull/209
THRIFT-2692 compiler refactor
https://issues.apache.org/jira/browse/THRIFT-2692
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hcorg/thrift