[GitHub] thrift pull request: THRIFT-2692 compiler refactor v2

2014-10-02 Thread hcorg
Github user hcorg commented on the pull request: https://github.com/apache/thrift/pull/210#issuecomment-57613963 closing - those changes are also part of THRIFT-2717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] thrift pull request: THRIFT-2692 compiler refactor v2

2014-10-02 Thread hcorg
Github user hcorg closed the pull request at: https://github.com/apache/thrift/pull/210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2692 compiler refactor v2

2014-09-08 Thread hcorg
GitHub user hcorg opened a pull request: https://github.com/apache/thrift/pull/210 THRIFT-2692 compiler refactor v2 this pull request contains some 'real' refactoring (of my own previous contribution) which shows how much adding new tests can help also I've created some