GitHub user radekg opened a pull request:
https://github.com/apache/thrift/pull/345
THRIFT-2926: JS: Binary protocol with unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radekg/thrift js-binary-protocol
Alternatively
Github user radekg commented on the pull request:
https://github.com/apache/thrift/pull/345#issuecomment-68580492
This build has failed because of some jslint issues. Any hints how can I
help resolving?
---
If your project is set up for it, you can reply to this email and have your
r
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/345#issuecomment-68587476
jslint is used via lib/js/test/build.xml which also runs the unit tests
test.js/test.html
My favorite would be integration of your tests into test.js/test.
Github user radekg commented on the pull request:
https://github.com/apache/thrift/pull/345#issuecomment-68589507
Thank you. I'll take a look at this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user radekg commented on the pull request:
https://github.com/apache/thrift/pull/345#issuecomment-68693024
@bufferoverflow I am trying to understand where the problem is. It seems
that travis is using a different method of testing than the one documented in
the README for js te
Github user radekg commented on the pull request:
https://github.com/apache/thrift/pull/345#issuecomment-68758030
I've done a little bit more research into this. There's a major issue which
will surface in the unit test once I can get it integrated. I've got the test
properly integrat
Github user radekg closed the pull request at:
https://github.com/apache/thrift/pull/345
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user radekg commented on the pull request:
https://github.com/apache/thrift/pull/345#issuecomment-68764557
And the code: https://github.com/radekg/thrift-js-binary-protocol
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user radekg reopened a pull request:
https://github.com/apache/thrift/pull/345
THRIFT-2926: JS: Binary protocol with unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radekg/thrift js-binary-protocol
Alternative
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/345#issuecomment-69494103
Thanks @radekg for this udate.
any idea about the jslint issues?
cd lib/js/test
make check
lib/js/test/build.xml:216: JSLint: 3
Github user radekg commented on the pull request:
https://github.com/apache/thrift/pull/345#issuecomment-69494149
On it and a broader discussion here:
https://issues.apache.org/jira/browse/THRIFT-2926
---
If your project is set up for it, you can reply to this email and have your
rep
11 matches
Mail list logo
