[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-11-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/512 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-11-04 Thread jfarrell
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/512#issuecomment-153717368 @marshalium I cut 0.9.3 off master, so everything in master or on the 0.9.3 branch should work for your testing --- If your project is set up for it, you can reply to

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-11-03 Thread marshalium
Github user marshalium commented on the pull request: https://github.com/apache/thrift/pull/512#issuecomment-153496623 Hey @jfarrell. Are things better with CI now? Should I rebase off of master and try again? Thanks! --- If your project is set up for it, you can reply to this email

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-07-21 Thread jfarrell
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/512#issuecomment-123525168 hey @marshalium, i'm working on cutting the 0.9.3 rc right now and using the docker containers in build/docker/ to do so. Travis is working to enable docker support and

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-07-21 Thread marshalium
Github user marshalium commented on the pull request: https://github.com/apache/thrift/pull/512#issuecomment-123489427 How do I kick off a new a build? I don't see any UI for that in Travis. Maybe it needs to be done by an administrator of some sort? I'm not optimistic that it

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-07-21 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/512#issuecomment-123485143 I've been kicking off new builds until it passes. I agree it doesn't look like the failure is related, but if you could keep kicking it until it does, that would be ide

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-07-21 Thread marshalium
Github user marshalium commented on the pull request: https://github.com/apache/thrift/pull/512#issuecomment-123464022 I believe all issues have been addressed. Is this blocked on something, or is there something I need to do to get this merged? --- If your project is set up for it,

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-07-08 Thread marshalium
Github user marshalium commented on the pull request: https://github.com/apache/thrift/pull/512#issuecomment-119705231 That build failure was different. Java tests passed, but it failed building the Haskell code. It seem unrelated: > cabal: Error: some packages failed to insta

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-07-08 Thread marshalium
Github user marshalium commented on the pull request: https://github.com/apache/thrift/pull/512#issuecomment-119674140 This new commit should take care of that test. Sorry about that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-07-08 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/512#issuecomment-119567052 BUILD FAILED /home/travis/build/apache/thrift/lib/java/build.xml:202: Test org.apache.thrift.transport.TestTFastFramedTransport failed --- If your project is set u

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-07-07 Thread marshalium
Github user marshalium commented on the pull request: https://github.com/apache/thrift/pull/512#issuecomment-119360734 I've pushed a commit that uses TTransportException instead of a new subclass. This should be ready to review again. --- If your project is set up for it, you can rep

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-07-07 Thread marshalium
Github user marshalium commented on a diff in the pull request: https://github.com/apache/thrift/pull/512#discussion_r34090086 --- Diff: lib/java/src/org/apache/thrift/transport/TInvalidFrameSizeException.java --- @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-07-07 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/512#discussion_r34083573 --- Diff: lib/java/src/org/apache/thrift/transport/TInvalidFrameSizeException.java --- @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-07-07 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/512#discussion_r34060609 --- Diff: lib/java/src/org/apache/thrift/transport/TInvalidFrameSizeException.java --- @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

2015-06-08 Thread marshalium
Github user marshalium commented on the pull request: https://github.com/apache/thrift/pull/512#issuecomment-110194778 Jira opened: https://issues.apache.org/jira/browse/THRIFT-3182 I added the new exception as a subclass of TTransportException exception type because I think i