[GitHub] thrift pull request: THRIFT-3382 TBase class for C++ Library

2015-11-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/653 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3382 TBase class for C++ Library

2015-10-14 Thread hcorg
Github user hcorg commented on a diff in the pull request: https://github.com/apache/thrift/pull/653#discussion_r42043448 --- Diff: lib/cpp/src/thrift/TBase.h --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] thrift pull request: THRIFT-3382 TBase class for C++ Library

2015-10-14 Thread hcorg
Github user hcorg commented on a diff in the pull request: https://github.com/apache/thrift/pull/653#discussion_r42043446 --- Diff: compiler/cpp/src/generate/t_cpp_generator.cc --- @@ -116,7 +116,8 @@ class t_cpp_generator : public t_oop_generator {

[GitHub] thrift pull request: THRIFT-3382 TBase class for C++ Library

2015-10-14 Thread hcorg
Github user hcorg commented on a diff in the pull request: https://github.com/apache/thrift/pull/653#discussion_r42045161 --- Diff: compiler/cpp/src/generate/t_cpp_generator.cc --- @@ -116,7 +116,8 @@ class t_cpp_generator : public t_oop_generator {

[GitHub] thrift pull request: THRIFT-3382 TBase class for C++ Library

2015-10-14 Thread beberg
GitHub user beberg opened a pull request: https://github.com/apache/thrift/pull/653 THRIFT-3382 TBase class for C++ Library Add a TBase that all Struct's use as their base class. Contributed by Sentient Technologies - http://www.sentient.ai/ You can merge this pull request into

[GitHub] thrift pull request: THRIFT-3382 TBase class for C++ Library

2015-10-14 Thread hcorg
Github user hcorg commented on a diff in the pull request: https://github.com/apache/thrift/pull/653#discussion_r42060020 --- Diff: lib/cpp/src/thrift/TBase.h --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor