Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/705
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/705#issuecomment-163678385
@thomaslee I agree it's cleaner and refined. Will merge shortly after.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user thomaslee commented on the pull request:
https://github.com/apache/thrift/pull/705#issuecomment-163522525
@nsuke how does this look? Ultimately did away with the setter entirely & I
think the API's a little cleaner for it.
In addition to applying your other
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/705#issuecomment-162261013
@thomaslee thanks for this, just added a couple of nits. It looks quite
neat :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/705#discussion_r46765197
--- Diff: lib/java/src/org/apache/thrift/transport/TByteBuffer.java ---
@@ -0,0 +1,88 @@
+package org.apache.thrift.transport;
+
+import
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/705#discussion_r46765176
--- Diff: lib/java/src/org/apache/thrift/transport/TByteBuffer.java ---
@@ -0,0 +1,88 @@
+package org.apache.thrift.transport;
+
+import
Github user thomaslee commented on the pull request:
https://github.com/apache/thrift/pull/705#issuecomment-162265175
Thanks for the review @nsuke, will land the changes soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user thomaslee commented on a diff in the pull request:
https://github.com/apache/thrift/pull/705#discussion_r46765943
--- Diff: lib/java/src/org/apache/thrift/transport/TByteBuffer.java ---
@@ -0,0 +1,88 @@
+package org.apache.thrift.transport;
+
+import
Github user thomaslee commented on a diff in the pull request:
https://github.com/apache/thrift/pull/705#discussion_r46765941
--- Diff: lib/java/src/org/apache/thrift/transport/TByteBuffer.java ---
@@ -0,0 +1,88 @@
+package org.apache.thrift.transport;
+
+import
Github user thomaslee commented on the pull request:
https://github.com/apache/thrift/pull/705#issuecomment-158567838
The other failure:
```
/home/travis/build/apache/thrift/lib/java/build.xml:148: Failed to copy
Github user thomaslee commented on the pull request:
https://github.com/apache/thrift/pull/705#issuecomment-158567751
hm afaict that build failure is unrelated to my change:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/92019024/log.txt
Failure is:
```
GitHub user thomaslee opened a pull request:
https://github.com/apache/thrift/pull/705
THRIFT-3432 Add the TByteBuffer transport for Java
A bounded, in-memory, optionally off-heap transport.
See https://issues.apache.org/jira/browse/THRIFT-3432 for more details.
You can
12 matches
Mail list logo
