Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/828
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/828#issuecomment-179694517
Tested with test/lua/test_basic_client.lua and test_basic_server.lua,
result is expected.
new comment(df693bf) added for the bug.
---
If your project is set up for
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/828#issuecomment-178683522
Tested with `test/lua/test_basic_client.lua` and found several problems.
Examples of problematic valus were negative i8 values (-128 ~ -1), some i32
values
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/828#discussion_r51591170
--- Diff: lib/lua/src/luabpack.c ---
@@ -103,7 +104,7 @@ static int l_bunpack(lua_State *L) {
const char *code = luaL_checkstring(L, 1);
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/828#issuecomment-177898858
@mygityf thanks for tidying things up, will look into it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mygityf closed the pull request at:
https://github.com/apache/thrift/pull/827
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user mygityf opened a pull request:
https://github.com/apache/thrift/pull/828
THRIFT-3585 Lua: compact protocol implement of lua for thrift.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gityf/thrift master
GitHub user mygityf opened a pull request:
https://github.com/apache/thrift/pull/827
THRIFT-3585 Lua: compact protocol implement of lua for thrift.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gityf/thrift lua-library
