[GitHub] thrift pull request: Thrift 3397

2015-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/663 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: Thrift 3397

2015-10-28 Thread JonathanH-UK
Github user JonathanH-UK commented on the pull request: https://github.com/apache/thrift/pull/663#issuecomment-152028971 New commit for review - I've rebased it as per the GitHub guidelines so I hope it's okay. The commit message contains a list of all the changes. It's still

[GitHub] thrift pull request: Thrift 3397

2015-10-27 Thread JonathanH-UK
GitHub user JonathanH-UK opened a pull request: https://github.com/apache/thrift/pull/663 Thrift 3397 2 Commits for consideration: 5cf0334 - Changes to C# Library Code (lib/csharp/src) 024c204 - Supporting changes to C# Test Code (lib/csharp/test) You can merge this pull

Re: [GitHub] thrift pull request: Thrift 3397 .

2015-10-27 Thread Nobuaki Sukegawa
Hi Jonathan, It fails a lot recently and seemingly it is due to out of memory. The other failure is a bit unusual. https://travis-ci.org/apache/thrift/jobs/87701311#L6671 You can view the actual failure log by clicking "after_failure" at the bottom. Only csharp-py_json can possibly be related

Re: [GitHub] thrift pull request: Thrift 3397 .

2015-10-27 Thread Jonathan Heard
Hi All, Disappointingly - After submitting my first pull request, the Travis CI build has failed the following job: https://travis-ci.org/apache/thrift/jobs/87701328 I would have built this on Travis CI before creating a pull request, but I'd already pushed the code to my branch and there seems