Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1196#discussion_r102025979
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1566,24 +1562,26 @@ void
TNonblockingIOThread::setCurrentThreadHighPriority(bool value) {
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1196#discussion_r102025490
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1566,24 +1562,26 @@ void
TNonblockingIOThread::setCurrentThreadHighPriority(bool value) {
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1196#discussion_r102025071
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1566,24 +1562,26 @@ void
TNonblockingIOThread::setCurrentThreadHighPriority(bool value) {
Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1196#discussion_r102023002
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1566,24 +1562,26 @@ void
TNonblockingIOThread::setCurrentThreadHighPriority(bool value) {
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1196#discussion_r101908414
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -820,9 +821,11 @@ void TNonblockingServer::TConnection::setFlags(short
eventFlags) {
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1196#discussion_r101908082
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1520,13 +1524,9 @@ void TNonblockingIOThread::breakLoop(bool error) {
::abort();
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1196#discussion_r101908056
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -212,7 +212,8 @@ class TNonblockingServer::TConnection {
TConnection(THRIFT_SOCKET soc
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1196#discussion_r101908102
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -820,9 +821,11 @@ void TNonblockingServer::TConnection::setFlags(short
eventFlags) {
*
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1196#discussion_r101908093
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -820,9 +821,11 @@ void TNonblockingServer::TConnection::setFlags(short
eventFlags) {
*
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1196
THRIFT-3891 TNonblockingServer configured with more than one IO threads
does not always return from serve() upon stop()
I took the comments from @nsuke and applied them to the PR. I was able to
r
11 matches
Mail list logo
